From: Sam Ravnborg <sam@ravnborg.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: linux-kbuild@vger.kernel.org, debian-kernel@lists.debian.org
Subject: Re: [PATCH] kbuild: Do not use hyphen in exported variable name
Date: Tue, 18 Apr 2017 06:44:18 +0200 [thread overview]
Message-ID: <20170418044418.GA10137@ravnborg.org> (raw)
In-Reply-To: <20170418010011.GC4152@decadent.org.uk>
On Tue, Apr 18, 2017 at 02:00:11AM +0100, Ben Hutchings wrote:
> This definition in Makefile.dtbinst:
>
> export dtbinst-root ?= $(obj)
>
> should define and export dtbinst-root when handling the root dts
> directory, and do nothing in the subdirectories. However, the
> variable does not reliably get exported to the environment, perhaps
> because its name contains a hyphen.
>
> Rename the variable to dtbinst_root.
Exported environment variables are usually in UPPPER CASE.
And also listed in: Documentation/kbuild/kbuild.txt
There are deviations from this already, so not something
that is followed by all of kbuild.
Sam
next prev parent reply other threads:[~2017-04-18 4:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 1:00 [PATCH] kbuild: Do not use hyphen in exported variable name Ben Hutchings
2017-04-18 4:44 ` Sam Ravnborg [this message]
2017-04-23 6:47 ` Masahiro Yamada
2017-04-23 7:23 ` Ben Hutchings
2017-04-30 14:14 ` Masahiro Yamada
2017-04-30 14:49 ` Ben Hutchings
2017-05-03 4:47 ` Masahiro Yamada
2017-08-19 1:13 ` Ben Hutchings
2017-08-19 17:37 ` Masahiro Yamada
2017-08-19 20:14 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418044418.GA10137@ravnborg.org \
--to=sam@ravnborg.org \
--cc=ben@decadent.org.uk \
--cc=debian-kernel@lists.debian.org \
--cc=linux-kbuild@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox