From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f49.google.com ([74.125.83.49]:34860 "EHLO mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811AbdFSQmU (ORCPT ); Mon, 19 Jun 2017 12:42:20 -0400 Received: by mail-pg0-f49.google.com with SMTP id 132so16861906pgb.2 for ; Mon, 19 Jun 2017 09:42:19 -0700 (PDT) Date: Mon, 19 Jun 2017 09:42:17 -0700 From: Matthias Kaehlcke Subject: Re: [PATCH v3 1/3] kbuild: Add __cc-option macro Message-ID: <20170619164217.GO141096@google.com> References: <20170615173715.40882-2-mka@chromium.org> <201706181420.ojaPWgL6%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Masahiro Yamada Cc: kbuild-all@01.org, Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , "H . J . Lu" , David Woodhouse , Michal Marek , X86 ML , Linux Kbuild mailing list , Linux Kernel Mailing List , Michael Davidson , Greg Hackmann , Nick Desaulniers , Stephen Hines , Kees Cook , Arnd Bergmann , Bernhard =?utf-8?Q?Rosenkr=C3=A4nzer?= , Peter Foley , Behan Webster , Douglas Anderson , kbuild test robot Hi Masahiro, El Mon, Jun 19, 2017 at 11:00:42AM +0900 Masahiro Yamada ha dit: > Sorry, the code I suggested introduced a slight behavior change. > > With this patch, cc-option adds a space before the returned option. > > > Please see line 46 of arch/sh/Makefile. > > ifeq ($(cflags-y),) > > > Now cflags-y contains a space, so > this conditional is now evaluated as false, > which was actually true without the patch. > This is the cause of the build error. Thanks for looking into this, I also didn't realize that the extra space could be an issue. > Could you remove whitespaces before $(1) and $(2) in cc-option? > > Also, please fix hostcc-option as well. Sure, I'll send out a new version soon. > 2017-06-18 15:58 GMT+09:00 kbuild test robot : > > Hi Matthias, > > > > [auto build test ERROR on tip/auto-latest] > > [also build test ERROR on v4.12-rc5 next-20170616] > > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > > > url: https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/kbuild-Add-__cc-option-macro/20170616-082252 > > config: sh-sh7710voipgw_defconfig (attached as .config) > > compiler: sh4-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 > > reproduce: > > wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # save the attached .config to linux build tree > > make.cross ARCH=sh > > > > All errors (new ones prefixed by >>): > > > > {standard input}: Assembler messages: > >>> {standard input}:672: Error: invalid operands for opcode > > {standard input}:673: Error: opcode not valid for this cpu variant > > {standard input}:674: Error: opcode not valid for this cpu variant > > {standard input}:675: Error: invalid operands for opcode > > {standard input}:1900: Error: invalid operands for opcode > > {standard input}:1901: Error: opcode not valid for this cpu variant > > {standard input}:1902: Error: opcode not valid for this cpu variant > > {standard input}:1903: Error: invalid operands for opcode > > {standard input}:2067: Error: invalid operands for opcode > > {standard input}:2068: Error: opcode not valid for this cpu variant > > {standard input}:2069: Error: opcode not valid for this cpu variant > > {standard input}:2070: Error: invalid operands for opcode > > {standard input}:2570: Error: invalid operands for opcode > > {standard input}:2571: Error: opcode not valid for this cpu variant > > {standard input}:2572: Error: opcode not valid for this cpu variant > > {standard input}:2573: Error: invalid operands for opcode > > > > --- > > 0-DAY kernel test infrastructure Open Source Technology Center > > https://lists.01.org/pipermail/kbuild-all Intel Corporation > > >