From: Ingo Molnar <mingo@kernel.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: hpa@zytor.com, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
"H . J . Lu" <hjl.tools@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <mmarek@suse.com>,
x86@kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, Michael Davidson <md@google.com>,
Greg Hackmann <ghackmann@google.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Stephen Hines <srhines@google.com>,
Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
Bernhard.Rosenkranzer@linaro.org,
Peter Foley <pefoley2@pefoley.com>,
Behan Webster <behanw@converseincode.com>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH v4 3/3] x86/build: Specify stack alignment for clang
Date: Tue, 20 Jun 2017 11:20:54 +0200 [thread overview]
Message-ID: <20170620092054.7d2mgzx6cw3jvgji@gmail.com> (raw)
In-Reply-To: <20170619204704.GP141096@google.com>
* Matthias Kaehlcke <mka@chromium.org> wrote:
> Ingo didn't like the duplication and suggested the use of a variable, which
> kinda implies a check for the compiler name.
I don't think it implies that: why cannot cc_stack_align_opt probe for the
compiler option and use whichever is available, without hard-coding the compiler
name?
> I also think this is a cleaner solution. [...]
I concur with hpa: hard-coding compiler is awfully fragile and ugly as well.
With the proper probing of compiler options it will be possible for compilers to
consolidate their options, and it would be possible for a third compiler to use a
mixture of GCC and Clang options. With hard-coding none of that flexibility is
available.
> but I'm happy to respin the patch if you have another suggestion that is ok for
> both of you.
Please do.
Thanks,
Ingo
next prev parent reply other threads:[~2017-06-20 9:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 18:37 [PATCH v4 0/3] x86: stack alignment for boot code and clang Matthias Kaehlcke
2017-06-19 18:37 ` [PATCH v4 1/3] kbuild: Add __cc-option macro Matthias Kaehlcke
2017-06-20 9:37 ` Masahiro Yamada
2017-06-19 18:37 ` [PATCH v4 2/3] x86/build: Use __cc-option for boot code compiler options Matthias Kaehlcke
2017-06-19 18:37 ` [PATCH v4 3/3] x86/build: Specify stack alignment for clang Matthias Kaehlcke
2017-06-19 20:17 ` hpa
2017-06-19 20:47 ` Matthias Kaehlcke
2017-06-20 9:20 ` Ingo Molnar [this message]
2017-06-20 17:37 ` Matthias Kaehlcke
2017-06-21 7:18 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620092054.7d2mgzx6cw3jvgji@gmail.com \
--to=mingo@kernel.org \
--cc=Bernhard.Rosenkranzer@linaro.org \
--cc=arnd@arndb.de \
--cc=behanw@converseincode.com \
--cc=dianders@chromium.org \
--cc=dwmw2@infradead.org \
--cc=ghackmann@google.com \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=md@google.com \
--cc=mingo@redhat.com \
--cc=mka@chromium.org \
--cc=mmarek@suse.com \
--cc=ndesaulniers@google.com \
--cc=pefoley2@pefoley.com \
--cc=srhines@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox