Re: [PATCH v4 3/3] x86/build: Specify stack alignment for clang

Ingo Molnar
2017-06-20T09:20:58Z

* Matthias Kaehlcke <mka@chromium.org> wrote:

> Ingo didn't like the duplication and suggested the use of a variable, which
> kinda implies a check for the compiler name.

I don't think it implies that: why cannot cc_stack_align_opt probe for the
compiler option and use whichever is available, without hard-coding the compiler
name?

> I also think this is a cleaner solution. [...]

I concur with hpa: hard-coding compiler is awfully fragile and ugly as well.

With the proper probing of compiler options it will be possible for compilers to
consolidate their options, and it would be possible for a third compiler to use a
mixture of GCC and Clang options. With hard-coding none of that flexibility is
available.

> but I'm happy to respin the patch if you have another suggestion that is ok for
> both of you.

Please do.

Thanks,

Ingo