Re: [PATCH 1/2] kbuild: clang: Disable 'address-of-packed-member' warning

Masahiro Yamada
2017-06-22T01:19:43Z

2017-05-17 6:32 GMT+09:00 Doug Anderson <dianders@chromium.org>:
> Hi,
>
> On Fri, Apr 21, 2017 at 2:39 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
>> clang generates plenty of these warnings in different parts of the code,
>> to an extent that the warnings are little more than noise. Disable the
>> 'address-of-packed-member' warning.
>>
>> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>> ---
>> Makefile | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Makefile b/Makefile
>> index 5039b9148d15..df5abf346354 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -703,6 +703,7 @@ KBUILD_CPPFLAGS += $(call cc-option,-Wno-unknown-warning-option,)
>> KBUILD_CFLAGS += $(call cc-disable-warning, unused-variable)
>> KBUILD_CFLAGS += $(call cc-disable-warning, format-invalid-specifier)
>> KBUILD_CFLAGS += $(call cc-disable-warning, gnu)
>> +KBUILD_CFLAGS += $(call cc-disable-warning, address-of-packed-member)
>> # Quiet clang warning: comparison of unsigned expression < 0 is always false
>> KBUILD_CFLAGS += $(call cc-disable-warning, tautological-compare)
>> # CLANG uses a _MergedGlobals as optimization, but this breaks modpost, as the
>
> Though I'm no expert, after reading the discussion on this thread and
> looking at the examples provided by Matthias, this seems sane to me.
> Thus, FWIW:
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

1/2 applied to linux-kbuild/kbuild. Thanks!

--
Best Regards
Masahiro Yamada