Re: [PATCH 1/4] kasan: support alloca() poisoning

Andrey Ryabinin
2017-07-14T16:49:50Z

On 07/14/2017 01:49 AM, Greg Hackmann wrote:
> On 07/10/2017 03:30 AM, Andrey Ryabinin wrote:
>> gcc now supports this too. So I think this patch should enable it.
>> It's off by default so you'll have to add --param asan-instrument-allocas=1 into cflags
>> to make it work
>
> Thanks, will fix. For now, it looks like I'll need to build gcc from git to test this?
>

Right, you'll need quite fresh revision >= 250032

>>> lib/test_kasan.c | 22 ++++++++++++++++++++++
>>
>> Tests would be better as a separate patch.
>
> I was following the precedent in 828347f8f9a5 ("kasan: support use-after-scope detection") which added both at the same time. But I can split the test off into a separate patch if you feel really strongly about it.

Please, do the split.