* [PATCH] kbuild: Update example for ccflags-y usage
@ 2017-07-24 15:27 Sedat Dilek
2017-08-07 20:24 ` Jonathan Corbet
0 siblings, 1 reply; 4+ messages in thread
From: Sedat Dilek @ 2017-07-24 15:27 UTC (permalink / raw)
To: Masahiro Yamada, Michal Marek, Jonathan Corbet, linux-kbuild,
linux-doc, linux-kernel
Cc: Sedat Dilek
From: Sedat Dilek <sedat.dilek@gmail.com>
The old example to describe ccflags-y usage is no more valid.
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
Documentation/kbuild/makefiles.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/kbuild/makefiles.txt b/Documentation/kbuild/makefiles.txt
index 7003141a6d4f..cadfa882c275 100644
--- a/Documentation/kbuild/makefiles.txt
+++ b/Documentation/kbuild/makefiles.txt
@@ -297,9 +297,9 @@ more details, with real examples.
ccflags-y specifies options for compiling with $(CC).
Example:
- # drivers/acpi/Makefile
- ccflags-y := -Os
- ccflags-$(CONFIG_ACPI_DEBUG) += -DACPI_DEBUG_OUTPUT
+ # drivers/acpi/acpica/Makefile
+ ccflags-y := -Os -D_LINUX -DBUILDING_ACPICA
+ ccflags-$(CONFIG_ACPI_DEBUG) += -DACPI_DEBUG_OUTPUT
This variable is necessary because the top Makefile owns the
variable $(KBUILD_CFLAGS) and uses it for compilation flags for the
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] kbuild: Update example for ccflags-y usage
2017-07-24 15:27 [PATCH] kbuild: Update example for ccflags-y usage Sedat Dilek
@ 2017-08-07 20:24 ` Jonathan Corbet
2017-08-08 12:36 ` Sedat Dilek
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Corbet @ 2017-08-07 20:24 UTC (permalink / raw)
To: Sedat Dilek
Cc: Masahiro Yamada, Michal Marek, linux-kbuild, linux-doc,
linux-kernel, Sedat Dilek
On Mon, 24 Jul 2017 17:27:05 +0200
Sedat Dilek <sedat.dilek@credativ.de> wrote:
> The old example to describe ccflags-y usage is no more valid.
>
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
I've applied this; had to clean up some whitespace weirdness on the way.
Thanks,
jon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kbuild: Update example for ccflags-y usage
2017-08-07 20:24 ` Jonathan Corbet
@ 2017-08-08 12:36 ` Sedat Dilek
2017-08-08 13:38 ` Jonathan Corbet
0 siblings, 1 reply; 4+ messages in thread
From: Sedat Dilek @ 2017-08-08 12:36 UTC (permalink / raw)
To: Jonathan Corbet
Cc: Sedat Dilek, Masahiro Yamada, Michal Marek, linux-kbuild,
linux-doc, linux-kernel
On Mon, Aug 7, 2017 at 10:24 PM, Jonathan Corbet <corbet@lwn.net> wrote:
> On Mon, 24 Jul 2017 17:27:05 +0200
> Sedat Dilek <sedat.dilek@credativ.de> wrote:
>
>> The old example to describe ccflags-y usage is no more valid.
>>
>> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
>
> I've applied this; had to clean up some whitespace weirdness on the way.
>
My apologies for this, forgot to run the checkpatch-script.
Will this go to Linux v4.13 or v4.14?
Thanks.
- Sedat -
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-08 13:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-24 15:27 [PATCH] kbuild: Update example for ccflags-y usage Sedat Dilek
2017-08-07 20:24 ` Jonathan Corbet
2017-08-08 12:36 ` Sedat Dilek
2017-08-08 13:38 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox