From: Greg K-H <gregkh@linuxfoundation.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org,
Markus Trippelsdorf <markus@trippelsdorf.de>,
Michal Marek <mmarek@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: rpm-pkg: delete firmware_install to fix build error
Date: Mon, 18 Sep 2017 11:24:12 +0200 [thread overview]
Message-ID: <20170918092412.GA21910@kroah.com> (raw)
In-Reply-To: <1505725956-11012-1-git-send-email-yamada.masahiro@socionext.com>
On Mon, Sep 18, 2017 at 06:12:36PM +0900, Masahiro Yamada wrote:
> Commit 5620a0d1aacd ("firmware: delete in-kernel firmware") deleted
> in-kernel firmware support, including "make firmware_install".
>
> Since then, "make rpm-pkg" / "make binrpm-pkg" fails to build with
> the error:
>
> make[2]: *** No rule to make target `firmware_install'. Stop.
>
> Commit df85b2d767aa ("firmware: Restore support for built-in firmware")
> restored the build infrastructure for CONFIG_EXTRA_FIRMWARE, but this
> is out of the scope of "make firmware_install". So, the right thing to
> do is to kill the use of "make firmware_install".
>
> Fixes: 5620a0d1aacd ("firmware: delete in-kernel firmware")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> scripts/package/mkspec | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
Nice find, what's the odds the debian package "script" also needs this
fix?
thanks,
greg k-h
next prev parent reply other threads:[~2017-09-18 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 9:12 [PATCH] kbuild: rpm-pkg: delete firmware_install to fix build error Masahiro Yamada
2017-09-18 9:24 ` Greg K-H [this message]
2017-09-18 9:24 ` Greg K-H
2017-09-20 15:53 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918092412.GA21910@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=mmarek@suse.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox