RE: [PATCH 10/11] selftests: futex: copy sub-dir test scripts for make O=dir run

Bird, Timothy
2017-09-13T18:15:18Z

> -----Original Message-----
> From: Shuah on Tuesday, September 12, 2017 4:53 PM
>
> For make O=dir run_tests to work, test scripts from sub-directories
> need to be copied over to the object directory. Running tests from the
> object directory is necessary to avoid making the source tree dirty.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> tools/testing/selftests/futex/Makefile | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/futex/Makefile
> b/tools/testing/selftests/futex/Makefile
> index 7c647f619d63..9358cb210fd5 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -11,10 +11,13 @@ all:
> BUILD_TARGET=$(OUTPUT)/$$DIR; \
> mkdir $$BUILD_TARGET -p; \
> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> + if [ -e $$DIR/$(TEST_PROGS) ]; then
> + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;

Same issue with rsync here. This could be a 'cp -a', if I'm not mistaken.

> + fi
> done
>
> override define RUN_TESTS
> - $(OUTPUT)/run.sh
> + cd $(OUTPUT); ./run.sh
> endef
>
> override define INSTALL_RULE
> --
> 2.11.0
>