From: Sam Ravnborg <sam@ravnborg.org>
To: Ulf Magnusson <ulfalizer@gmail.com>
Cc: linux-kbuild@vger.kernel.org, yamada.masahiro@socionext.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] kconfig: 'if' and automatic submenu creation documentation
Date: Sun, 14 Jan 2018 22:00:48 +0100 [thread overview]
Message-ID: <20180114210048.GA11442@ravnborg.org> (raw)
In-Reply-To: <20180114113345.18623-1-ulfalizer@gmail.com>
Hi Ulf.
On Sun, Jan 14, 2018 at 12:33:43PM +0100, Ulf Magnusson wrote:
> These together should make the automatic submenu logic a lot clearer.
>
> Ulf Magnusson (2):
> kconfig: Document 'if' flattening logic
> kconfig: Improve auto. menu documentation accuracy
>
> scripts/kconfig/menu.c | 33 +++++++++++++++++++++++++++++----
> 1 file changed, 29 insertions(+), 4 deletions(-)
Very good with extra comments in menu_finalize.
If you can mamage to explain the logic related to select
then even better.
While on the subject on improving readability, then
menu_finalize would benefit from a split in a number of
well named and well documented helper functions.
It would be great if you could try this out.
Sam
next prev parent reply other threads:[~2018-01-14 21:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 11:33 [PATCH 0/2] kconfig: 'if' and automatic submenu creation documentation Ulf Magnusson
2018-01-14 11:33 ` [PATCH 1/2] kconfig: Document 'if' flattening logic Ulf Magnusson
2018-01-14 11:38 ` Ulf Magnusson
2018-01-14 11:38 ` [PATCH 2/2] kconfig: Improve auto. menu documentation accuracy Ulf Magnusson
2018-01-18 13:54 ` Masahiro Yamada
2018-01-14 14:49 ` [PATCH v2 1/2] kconfig: Document 'if' flattening logic Ulf Magnusson
2018-01-21 16:47 ` Masahiro Yamada
2018-01-14 21:00 ` Sam Ravnborg [this message]
2018-01-15 11:00 ` [PATCH 0/2] kconfig: 'if' and automatic submenu creation documentation Ulf Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180114210048.GA11442@ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ulfalizer@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox