[PATCH] kconfig: Clarify menu and 'if' dependency propagation

[PATCH] kconfig: Clarify menu and 'if' dependency propagation

[Ulf Magnusson]

It is not obvious that the last two cases refer to menus and ifs,
respectively, in the conditional that sets 'parentdep'.

Automatic submenu creation is done later, so the parent can't be a
symbol here.

No functional changes. Only comments added.

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 scripts/kconfig/menu.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index 92d3f06cd8a2..b81c9b053f6e 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -325,8 +325,10 @@ void menu_finalize(struct menu *parent)
 			}
 			parentdep = expr_alloc_symbol(sym);
 		} else if (parent->prompt)
+			/* Menu node for 'menu' */
 			parentdep = parent->prompt->visible.expr;
 		else
+			/* Menu node for 'if' */
 			parentdep = parent->dep;
 
 		/* For each child menu node... */
-- 
2.14.1

Re: [PATCH] kconfig: Clarify menu and 'if' dependency propagation

[Masahiro Yamada]

2018-01-17 5:39 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
> It is not obvious that the last two cases refer to menus and ifs,
> respectively, in the conditional that sets 'parentdep'.
>
> Automatic submenu creation is done later, so the parent can't be a
> symbol here.
>
> No functional changes. Only comments added.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
>  scripts/kconfig/menu.c | 2 ++

Applied to linux-kbuild/kconfig.  Thanks!

-- 
Best Regards
Masahiro Yamada