* [PATCH v2 01/10] net/sched: kconfig: Remove empty help texts
2018-01-30 19:22 [PATCH v2 00/10] Remove empty help texts from Kconfig files Ulf Magnusson
@ 2018-01-30 19:22 ` Ulf Magnusson
2018-01-30 19:22 ` [PATCH v2 02/10] video: fbdev: kconfig: Remove empty help text Ulf Magnusson
` (9 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Ulf Magnusson @ 2018-01-30 19:22 UTC (permalink / raw)
To: linux-kbuild
Cc: linux-kernel, yamada.masahiro, mcgrof, Ulf Magnusson,
Jamal Hadi Salim, Cong Wang, Jiri Pirko, David S. Miller, netdev
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
net/sched/Kconfig | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/sched/Kconfig b/net/sched/Kconfig
index c03d86a7775e..f24a6ae6819a 100644
--- a/net/sched/Kconfig
+++ b/net/sched/Kconfig
@@ -857,17 +857,14 @@ config NET_ACT_TUNNEL_KEY
config NET_IFE_SKBMARK
tristate "Support to encoding decoding skb mark on IFE action"
depends on NET_ACT_IFE
- ---help---
config NET_IFE_SKBPRIO
tristate "Support to encoding decoding skb prio on IFE action"
depends on NET_ACT_IFE
- ---help---
config NET_IFE_SKBTCINDEX
tristate "Support to encoding decoding skb tcindex on IFE action"
depends on NET_ACT_IFE
- ---help---
config NET_CLS_IND
bool "Incoming device classification"
--
2.14.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2 02/10] video: fbdev: kconfig: Remove empty help text
2018-01-30 19:22 [PATCH v2 00/10] Remove empty help texts from Kconfig files Ulf Magnusson
2018-01-30 19:22 ` [PATCH v2 01/10] net/sched: kconfig: Remove empty help texts Ulf Magnusson
@ 2018-01-30 19:22 ` Ulf Magnusson
2018-01-30 19:22 ` [PATCH v2 03/10] mmc: " Ulf Magnusson
` (8 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Ulf Magnusson @ 2018-01-30 19:22 UTC (permalink / raw)
To: linux-kbuild
Cc: linux-kernel, yamada.masahiro, mcgrof, Ulf Magnusson,
Bartlomiej Zolnierkiewicz, Michal Simek, Randy Dunlap,
Arnd Bergmann, Hans de Goede, dri-devel, linux-fbdev
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
drivers/video/fbdev/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 6962b4583fd7..11e699f1062b 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1156,7 +1156,6 @@ config FB_I810_I2C
bool "Enable DDC Support"
depends on FB_I810 && FB_I810_GTF
select FB_DDC
- help
config FB_LE80578
tristate "Intel LE80578 (Vermilion) support"
--
2.14.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2 03/10] mmc: kconfig: Remove empty help text
2018-01-30 19:22 [PATCH v2 00/10] Remove empty help texts from Kconfig files Ulf Magnusson
2018-01-30 19:22 ` [PATCH v2 01/10] net/sched: kconfig: Remove empty help texts Ulf Magnusson
2018-01-30 19:22 ` [PATCH v2 02/10] video: fbdev: kconfig: Remove empty help text Ulf Magnusson
@ 2018-01-30 19:22 ` Ulf Magnusson
2018-01-30 19:22 ` [PATCH v2 04/10] Staging: rtl8192u: " Ulf Magnusson
` (7 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Ulf Magnusson @ 2018-01-30 19:22 UTC (permalink / raw)
To: linux-kbuild
Cc: linux-kernel, yamada.masahiro, mcgrof, Ulf Magnusson, Ulf Hansson,
Adrian Hunter, Wolfram Sang, Arnd Bergmann, Jan Glauber,
Simon Horman, Shawn Lin, Eric Anholt, Carlo Caione,
Venkat Gopalakrishnan, Kishon Vijay Abraham I, Andy Shevchenko,
Rui Feng, Srinivas Kandagatla, linux-mmc
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
drivers/mmc/host/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 67bd3344dd03..24dee8eb5270 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -874,7 +874,6 @@ config MMC_CQHCI
config MMC_TOSHIBA_PCI
tristate "Toshiba Type A SD/MMC Card Interface Driver"
depends on PCI
- help
config MMC_BCM2835
tristate "Broadcom BCM2835 SDHOST MMC Controller support"
--
2.14.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2 04/10] Staging: rtl8192u: kconfig: Remove empty help text
2018-01-30 19:22 [PATCH v2 00/10] Remove empty help texts from Kconfig files Ulf Magnusson
` (2 preceding siblings ...)
2018-01-30 19:22 ` [PATCH v2 03/10] mmc: " Ulf Magnusson
@ 2018-01-30 19:22 ` Ulf Magnusson
2018-01-30 19:23 ` [PATCH v2 05/10] Staging: rtl8192e: " Ulf Magnusson
` (6 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Ulf Magnusson @ 2018-01-30 19:22 UTC (permalink / raw)
To: linux-kbuild
Cc: linux-kernel, yamada.masahiro, mcgrof, Ulf Magnusson,
Greg Kroah-Hartman, devel
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
drivers/staging/rtl8192u/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/Kconfig b/drivers/staging/rtl8192u/Kconfig
index 3ee9d0d00fb6..97df6507a485 100644
--- a/drivers/staging/rtl8192u/Kconfig
+++ b/drivers/staging/rtl8192u/Kconfig
@@ -5,4 +5,3 @@ config RTL8192U
select WIRELESS_EXT
select WEXT_PRIV
select CRYPTO
- ---help---
--
2.14.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2 05/10] Staging: rtl8192e: kconfig: Remove empty help text
2018-01-30 19:22 [PATCH v2 00/10] Remove empty help texts from Kconfig files Ulf Magnusson
` (3 preceding siblings ...)
2018-01-30 19:22 ` [PATCH v2 04/10] Staging: rtl8192u: " Ulf Magnusson
@ 2018-01-30 19:23 ` Ulf Magnusson
2018-01-30 19:23 ` [PATCH v2 06/10] lib/Kconfig.debug: " Ulf Magnusson
` (5 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Ulf Magnusson @ 2018-01-30 19:23 UTC (permalink / raw)
To: linux-kbuild
Cc: linux-kernel, yamada.masahiro, mcgrof, Ulf Magnusson,
Greg Kroah-Hartman, devel
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/Kconfig b/drivers/staging/rtl8192e/rtl8192e/Kconfig
index 282e293da18f..7ac42a590e21 100644
--- a/drivers/staging/rtl8192e/rtl8192e/Kconfig
+++ b/drivers/staging/rtl8192e/rtl8192e/Kconfig
@@ -6,4 +6,3 @@ config RTL8192E
select WEXT_PRIV
select CRYPTO
select FW_LOADER
- ---help---
--
2.14.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2 06/10] lib/Kconfig.debug: Remove empty help text
2018-01-30 19:22 [PATCH v2 00/10] Remove empty help texts from Kconfig files Ulf Magnusson
` (4 preceding siblings ...)
2018-01-30 19:23 ` [PATCH v2 05/10] Staging: rtl8192e: " Ulf Magnusson
@ 2018-01-30 19:23 ` Ulf Magnusson
2018-01-30 19:23 ` [PATCH v2 07/10] MIPS: BCM63XX: kconfig: " Ulf Magnusson
` (4 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Ulf Magnusson @ 2018-01-30 19:23 UTC (permalink / raw)
To: linux-kbuild
Cc: linux-kernel, yamada.masahiro, mcgrof, Ulf Magnusson, Ingo Molnar,
Andrew Morton, Byungchul Park, Peter Zijlstra, Paul E. McKenney,
Geert Uytterhoeven, Josh Poimboeuf, Randy Dunlap, Nicholas Piggin,
Theodore Ts'o
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
lib/Kconfig.debug | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index b66c264d4194..6088408ef26c 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -351,7 +351,6 @@ config SECTION_MISMATCH_WARN_ONLY
#
config ARCH_WANT_FRAME_POINTERS
bool
- help
config FRAME_POINTER
bool "Compile the kernel with frame pointers"
--
2.14.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2 07/10] MIPS: BCM63XX: kconfig: Remove empty help text
2018-01-30 19:22 [PATCH v2 00/10] Remove empty help texts from Kconfig files Ulf Magnusson
` (5 preceding siblings ...)
2018-01-30 19:23 ` [PATCH v2 06/10] lib/Kconfig.debug: " Ulf Magnusson
@ 2018-01-30 19:23 ` Ulf Magnusson
2018-01-30 19:23 ` [PATCH v2 08/10] MIPS: " Ulf Magnusson
` (3 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Ulf Magnusson @ 2018-01-30 19:23 UTC (permalink / raw)
To: linux-kbuild
Cc: linux-kernel, yamada.masahiro, mcgrof, Ulf Magnusson,
Ralf Baechle, James Hogan, Florian Fainelli,
bcm-kernel-feedback-list, Greg Kroah-Hartman, Philippe Ombredanne,
Kate Stewart, Thomas Gleixner, linux-mips, linux-arm-kernel
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
arch/mips/bcm63xx/boards/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/bcm63xx/boards/Kconfig b/arch/mips/bcm63xx/boards/Kconfig
index 6ff0a7481081..f60d96610ace 100644
--- a/arch/mips/bcm63xx/boards/Kconfig
+++ b/arch/mips/bcm63xx/boards/Kconfig
@@ -7,6 +7,5 @@ choice
config BOARD_BCM963XX
bool "Generic Broadcom 963xx boards"
select SSB
- help
endchoice
--
2.14.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2 08/10] MIPS: kconfig: Remove empty help text
2018-01-30 19:22 [PATCH v2 00/10] Remove empty help texts from Kconfig files Ulf Magnusson
` (6 preceding siblings ...)
2018-01-30 19:23 ` [PATCH v2 07/10] MIPS: BCM63XX: kconfig: " Ulf Magnusson
@ 2018-01-30 19:23 ` Ulf Magnusson
2018-01-30 19:23 ` [PATCH v2 09/10] arm: vt8500: " Ulf Magnusson
` (2 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Ulf Magnusson @ 2018-01-30 19:23 UTC (permalink / raw)
To: linux-kbuild
Cc: linux-kernel, yamada.masahiro, mcgrof, Ulf Magnusson,
Ralf Baechle, James Hogan, linux-mips
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
arch/mips/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index ab98569994f0..57cd591e7b28 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2326,7 +2326,6 @@ config MIPS_VPE_LOADER_TOM
config MIPS_VPE_APSP_API
bool "Enable support for AP/SP API (RTLX)"
depends on MIPS_VPE_LOADER
- help
config MIPS_VPE_APSP_API_CMP
bool
--
2.14.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2 09/10] arm: vt8500: kconfig: Remove empty help text
2018-01-30 19:22 [PATCH v2 00/10] Remove empty help texts from Kconfig files Ulf Magnusson
` (7 preceding siblings ...)
2018-01-30 19:23 ` [PATCH v2 08/10] MIPS: " Ulf Magnusson
@ 2018-01-30 19:23 ` Ulf Magnusson
2018-01-30 19:23 ` [PATCH v2 10/10] nios2: " Ulf Magnusson
2018-01-30 21:00 ` [PATCH v2 00/10] Remove empty help texts from Kconfig files Randy Dunlap
10 siblings, 0 replies; 13+ messages in thread
From: Ulf Magnusson @ 2018-01-30 19:23 UTC (permalink / raw)
To: linux-kbuild
Cc: linux-kernel, yamada.masahiro, mcgrof, Ulf Magnusson, Tony Prisk,
Russell King, linux-arm-kernel
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
arch/arm/mach-vt8500/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-vt8500/Kconfig b/arch/arm/mach-vt8500/Kconfig
index 1156a585dafc..8841199058ea 100644
--- a/arch/arm/mach-vt8500/Kconfig
+++ b/arch/arm/mach-vt8500/Kconfig
@@ -13,7 +13,6 @@ config ARCH_WM8505
depends on ARCH_MULTI_V5
select ARCH_VT8500
select CPU_ARM926T
- help
config ARCH_WM8750
bool "WonderMedia WM8750"
--
2.14.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2 10/10] nios2: kconfig: Remove empty help text
2018-01-30 19:22 [PATCH v2 00/10] Remove empty help texts from Kconfig files Ulf Magnusson
` (8 preceding siblings ...)
2018-01-30 19:23 ` [PATCH v2 09/10] arm: vt8500: " Ulf Magnusson
@ 2018-01-30 19:23 ` Ulf Magnusson
2018-01-30 21:00 ` [PATCH v2 00/10] Remove empty help texts from Kconfig files Randy Dunlap
10 siblings, 0 replies; 13+ messages in thread
From: Ulf Magnusson @ 2018-01-30 19:23 UTC (permalink / raw)
To: linux-kbuild
Cc: linux-kernel, yamada.masahiro, mcgrof, Ulf Magnusson,
Ley Foon Tan, nios2-dev
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
arch/nios2/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig
index 60fae03dac79..3d4ec88f1db1 100644
--- a/arch/nios2/Kconfig
+++ b/arch/nios2/Kconfig
@@ -152,7 +152,6 @@ menu "Advanced setup"
config ADVANCED_OPTIONS
bool "Prompt for advanced kernel configuration options"
- help
comment "Default settings for advanced configuration options are used"
depends on !ADVANCED_OPTIONS
--
2.14.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v2 00/10] Remove empty help texts from Kconfig files
2018-01-30 19:22 [PATCH v2 00/10] Remove empty help texts from Kconfig files Ulf Magnusson
` (9 preceding siblings ...)
2018-01-30 19:23 ` [PATCH v2 10/10] nios2: " Ulf Magnusson
@ 2018-01-30 21:00 ` Randy Dunlap
2018-01-31 9:46 ` Ulf Magnusson
10 siblings, 1 reply; 13+ messages in thread
From: Randy Dunlap @ 2018-01-30 21:00 UTC (permalink / raw)
To: Ulf Magnusson, linux-kbuild; +Cc: linux-kernel, yamada.masahiro, mcgrof
On 01/30/2018 11:22 AM, Ulf Magnusson wrote:
> Empty help texts are probably either a typo, a Kconfig misunderstanding, or
> some kind of half-committing to adding a help text (in which case a TODO
> comment would be clearer, if the help text really can't be added right away).
> Best to flag them, IMO.
>
> Changes since v1:
>
> Forgot to send the cover letter to linux-kbuild.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> Ulf Magnusson (10):
> net/sched: kconfig: Remove empty help texts
> video: fbdev: kconfig: Remove empty help text
> mmc: kconfig: Remove empty help text
> Staging: rtl8192u: kconfig: Remove empty help text
> Staging: rtl8192e: kconfig: Remove empty help text
> lib/Kconfig.debug: Remove empty help text
> MIPS: BCM63XX: kconfig: Remove empty help text
> MIPS: kconfig: Remove empty help text
> arm: vt8500: kconfig: Remove empty help text
> nios2: kconfig: Remove empty help text
>
> arch/arm/mach-vt8500/Kconfig | 1 -
> arch/mips/Kconfig | 1 -
> arch/mips/bcm63xx/boards/Kconfig | 1 -
> arch/nios2/Kconfig | 1 -
> drivers/mmc/host/Kconfig | 1 -
> drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
> drivers/staging/rtl8192u/Kconfig | 1 -
> drivers/video/fbdev/Kconfig | 1 -
> lib/Kconfig.debug | 1 -
> net/sched/Kconfig | 3 ---
> 10 files changed, 12 deletions(-)
>
--
~Randy
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2 00/10] Remove empty help texts from Kconfig files
2018-01-30 21:00 ` [PATCH v2 00/10] Remove empty help texts from Kconfig files Randy Dunlap
@ 2018-01-31 9:46 ` Ulf Magnusson
0 siblings, 0 replies; 13+ messages in thread
From: Ulf Magnusson @ 2018-01-31 9:46 UTC (permalink / raw)
To: Randy Dunlap
Cc: Linux Kbuild mailing list, Linux Kernel Mailing List,
Masahiro Yamada, Luis R . Rodriguez
On Tue, Jan 30, 2018 at 10:00 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> On 01/30/2018 11:22 AM, Ulf Magnusson wrote:
>> Empty help texts are probably either a typo, a Kconfig misunderstanding, or
>> some kind of half-committing to adding a help text (in which case a TODO
>> comment would be clearer, if the help text really can't be added right away).
>> Best to flag them, IMO.
>>
>> Changes since v1:
>>
>> Forgot to send the cover letter to linux-kbuild.
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
> Thanks.
>
>> Ulf Magnusson (10):
>> net/sched: kconfig: Remove empty help texts
>> video: fbdev: kconfig: Remove empty help text
>> mmc: kconfig: Remove empty help text
>> Staging: rtl8192u: kconfig: Remove empty help text
>> Staging: rtl8192e: kconfig: Remove empty help text
>> lib/Kconfig.debug: Remove empty help text
>> MIPS: BCM63XX: kconfig: Remove empty help text
>> MIPS: kconfig: Remove empty help text
>> arm: vt8500: kconfig: Remove empty help text
>> nios2: kconfig: Remove empty help text
>>
>> arch/arm/mach-vt8500/Kconfig | 1 -
>> arch/mips/Kconfig | 1 -
>> arch/mips/bcm63xx/boards/Kconfig | 1 -
>> arch/nios2/Kconfig | 1 -
>> drivers/mmc/host/Kconfig | 1 -
>> drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
>> drivers/staging/rtl8192u/Kconfig | 1 -
>> drivers/video/fbdev/Kconfig | 1 -
>> lib/Kconfig.debug | 1 -
>> net/sched/Kconfig | 3 ---
>> 10 files changed, 12 deletions(-)
>>
>
>
> --
> ~Randy
This patchset has been superseded by
https://lkml.org/lkml/2018/1/31/137, which rolls the removal of the
blank help texts and adding the new warning into a single patchset.
Cheers,
Ulf
^ permalink raw reply [flat|nested] 13+ messages in thread