From: Eugeniu Rosca <roscaeugeniu@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
Ulf Magnusson <ulfalizer@gmail.com>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Randy Dunlap <rdunlap@infradead.org>,
Petr Vorel <petr.vorel@gmail.com>,
Paul Bolle <pebolle@tiscali.nl>
Cc: Eugeniu Rosca <erosca@de.adit-jv.com>,
linux-kbuild@vger.kernel.org,
Eugeniu Rosca <rosca.eugeniu@gmail.com>
Subject: [PATCH 2/2] kconfig: Print the value of each reverse dependency
Date: Tue, 13 Feb 2018 01:56:10 +0100 [thread overview]
Message-ID: <20180213005610.10575-2-rosca.eugeniu@gmail.com> (raw)
In-Reply-To: <20180213005610.10575-1-rosca.eugeniu@gmail.com>
From: Eugeniu Rosca <erosca@de.adit-jv.com>
Assuming commit 617aebe6a97e ("Merge tag 'usercopy-v4.16-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux"), ARCH=arm64
and vanilla arm64 defconfig, here is the top 10 CONFIG options with
the highest amount of OR sub-expressions that make up the final
"{Selected,Implied} by" reverse dependency expression.
| Config | Revdep all | Revdep ![=n] |
|-------------------------------|------------|--------------|
| REGMAP_I2C | 212 | 9 |
| CRC32 | 167 | 25 |
| FW_LOADER | 128 | 5 |
| MFD_CORE | 124 | 9 |
| FB_CFB_IMAGEBLIT | 114 | 2 |
| FB_CFB_COPYAREA | 111 | 2 |
| FB_CFB_FILLRECT | 110 | 2 |
| SND_PCM | 103 | 2 |
| CRYPTO_HASH | 87 | 19 |
| WATCHDOG_CORE | 86 | 6 |
The story behind the above table is that the user needs to visually
review/evaluate 212 expressions which *potentially* select REGMAP_I2C
in order to identify the expressions which *actually* select REGMAP_I2C,
for a particular ARCH and for a particular defconfig used.
To make this experience smoother, transform the way reverse dependencies
are displayed to the user from [1] to [2].
[1] Before this commit
Symbol: MTD_BLKDEVS [=y]
...
Selected by:
- MTD_BLOCK [=y] && MTD [=y] && BLOCK [=y]
- MTD_BLOCK_RO [=n] && MTD [=y] && MTD_BLOCK [=y]!=y && BLOCK [=y]
- FTL [=n] && MTD [=y] && BLOCK [=y]
- NFTL [=n] && MTD [=y] && BLOCK [=y]
- INFTL [=n] && MTD [=y] && BLOCK [=y]
- RFD_FTL [=n] && MTD [=y] && BLOCK [=y]
- SSFDC [=n] && MTD [=y] && BLOCK [=y]
- SM_FTL [=n] && MTD [=y] && BLOCK [=y]
- MTD_SWAP [=n] && MTD [=y] && SWAP [=y]
[2] After this commit
Symbol: MTD_BLKDEVS [=y]
...
Selected by:
- [y] MTD_BLOCK [=y] && MTD [=y] && BLOCK [=y]
- [ ] MTD_BLOCK_RO [=n] && MTD [=y] && MTD_BLOCK [=y]!=y && BLOCK [=y]
- [ ] FTL [=n] && MTD [=y] && BLOCK [=y]
- [ ] NFTL [=n] && MTD [=y] && BLOCK [=y]
- [ ] INFTL [=n] && MTD [=y] && BLOCK [=y]
- [ ] RFD_FTL [=n] && MTD [=y] && BLOCK [=y]
- [ ] SSFDC [=n] && MTD [=y] && BLOCK [=y]
- [ ] SM_FTL [=n] && MTD [=y] && BLOCK [=y]
- [ ] MTD_SWAP [=n] && MTD [=y] && SWAP [=y]
This patch has been tested using a custom variant of zconfdump which
prints the reverse dependencies for each config symbol.
Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Suggested-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
---
scripts/kconfig/expr.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/scripts/kconfig/expr.c b/scripts/kconfig/expr.c
index 0704bcdf4c78..173fc5b252d5 100644
--- a/scripts/kconfig/expr.c
+++ b/scripts/kconfig/expr.c
@@ -1185,7 +1185,19 @@ expr_print_newline(struct expr *e,
void *data,
int prevtoken)
{
- fn(data, NULL, "\n - ");
+ switch (expr_calc_value(e)) {
+ case yes:
+ fn(data, NULL, "\n - [y] ");
+ break;
+ case mod:
+ fn(data, NULL, "\n - [m] ");
+ break;
+ case no:
+ fn(data, NULL, "\n - [ ] ");
+ break;
+ default:
+ break;
+ }
expr_print(e, fn, data, prevtoken);
}
--
2.16.1
next prev parent reply other threads:[~2018-02-13 0:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 0:56 [PATCH 1/2] kconfig: Print reverse dependencies on new line consistently Eugeniu Rosca
2018-02-13 0:56 ` Eugeniu Rosca [this message]
2018-02-13 6:18 ` [PATCH 2/2] kconfig: Print the value of each reverse dependency Ulf Magnusson
2018-02-13 23:54 ` Eugeniu Rosca
2018-02-14 0:41 ` Petr Vorel
2018-02-17 17:26 ` Eugeniu Rosca
2018-02-14 4:09 ` Ulf Magnusson
2018-02-17 17:20 ` Eugeniu Rosca
2018-02-17 17:31 ` Ulf Magnusson
2018-02-18 11:34 ` Eugeniu Rosca
2018-02-14 0:46 ` Petr Vorel
2018-02-13 6:11 ` [PATCH 1/2] kconfig: Print reverse dependencies on new line consistently Ulf Magnusson
2018-02-13 6:40 ` Petr Vorel
2018-02-14 0:32 ` Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213005610.10575-2-rosca.eugeniu@gmail.com \
--to=roscaeugeniu@gmail.com \
--cc=erosca@de.adit-jv.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=pebolle@tiscali.nl \
--cc=petr.vorel@gmail.com \
--cc=rdunlap@infradead.org \
--cc=rosca.eugeniu@gmail.com \
--cc=ulfalizer@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox