From: Eugeniu Rosca <roscaeugeniu@gmail.com>
To: Petr Vorel <petr.vorel@gmail.com>
Cc: Ulf Magnusson <ulfalizer@gmail.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Randy Dunlap <rdunlap@infradead.org>,
Paul Bolle <pebolle@tiscali.nl>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Eugeniu Rosca <rosca.eugeniu@gmail.com>,
Eugeniu Rosca <erosca@de.adit-jv.com>
Subject: Re: [PATCH 1/2] kconfig: Print reverse dependencies on new line consistently
Date: Wed, 14 Feb 2018 01:32:48 +0100 [thread overview]
Message-ID: <20180214003248.GA2256@example.com> (raw)
In-Reply-To: <20180213064029.GA1587@x230>
Hi Petr,
On Tue, Feb 13, 2018 at 07:40:30AM +0100, Petr Vorel wrote:
> Hi Eugeniu,
>
> > On Tue, Feb 13, 2018 at 1:56 AM, Eugeniu Rosca <roscaeugeniu@gmail.com> wrote:
> > > From: Eugeniu Rosca <erosca@de.adit-jv.com>
>
> > > Commit 1ccb27143360 ("kconfig: make "Selected by:" and "Implied by:"
> > > readable") made an incredible improvement in how reverse dependencies
> > > are perceived by the user, by breaking down the single (often
> > > interminable) expression string into small readable chunks, each of
> > > them displayed on a separate line:
>
> > > Selected by:
> > > - A & B
> > > - C & (D || E)
>
> > > Unfortunately, what happens with the non-OR (either E_SYMBOL or E_AND)
> > > expressions is that they don't get a dedicated line:
>
> > > Selected by: F & G
> I deliberately choose it :-). It didn't make much sense for me to add new line for just
> one line. I thought someone wouldn't like it for the inconsistency :-).
I have to say I do like how `Selected by: F && G` looks on a single row.
However, when the expression is prefixed by its value (i.e.
`Selected by: [m] F && G`), imho it doesn't look as crisp and clear
as we would like it to (feel free to disagree here). Fwiw, this patch
doesn't see itself as a fix, but rather prepares the ground for the next
commit implementing prefixing reverse dependencies by their expression
value.
>
> Kind regards,
> Petr
Thanks!
Eugeniu.
prev parent reply other threads:[~2018-02-14 0:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 0:56 [PATCH 1/2] kconfig: Print reverse dependencies on new line consistently Eugeniu Rosca
2018-02-13 0:56 ` [PATCH 2/2] kconfig: Print the value of each reverse dependency Eugeniu Rosca
2018-02-13 6:18 ` Ulf Magnusson
2018-02-13 23:54 ` Eugeniu Rosca
2018-02-14 0:41 ` Petr Vorel
2018-02-17 17:26 ` Eugeniu Rosca
2018-02-14 4:09 ` Ulf Magnusson
2018-02-17 17:20 ` Eugeniu Rosca
2018-02-17 17:31 ` Ulf Magnusson
2018-02-18 11:34 ` Eugeniu Rosca
2018-02-14 0:46 ` Petr Vorel
2018-02-13 6:11 ` [PATCH 1/2] kconfig: Print reverse dependencies on new line consistently Ulf Magnusson
2018-02-13 6:40 ` Petr Vorel
2018-02-14 0:32 ` Eugeniu Rosca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214003248.GA2256@example.com \
--to=roscaeugeniu@gmail.com \
--cc=erosca@de.adit-jv.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=pebolle@tiscali.nl \
--cc=petr.vorel@gmail.com \
--cc=rdunlap@infradead.org \
--cc=rosca.eugeniu@gmail.com \
--cc=ulfalizer@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox