From: Petr Vorel <petr.vorel@gmail.com>
To: Eugeniu Rosca <roscaeugeniu@gmail.com>
Cc: Ulf Magnusson <ulfalizer@gmail.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Randy Dunlap <rdunlap@infradead.org>,
Paul Bolle <pebolle@tiscali.nl>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Eugeniu Rosca <rosca.eugeniu@gmail.com>,
Eugeniu Rosca <erosca@de.adit-jv.com>
Subject: Re: [PATCH 2/2] kconfig: Print the value of each reverse dependency
Date: Wed, 14 Feb 2018 01:41:54 +0100 [thread overview]
Message-ID: <20180214004153.GA1154@x230> (raw)
In-Reply-To: <20180213235448.GA30690@example.com>
Hi Eugeniu,
> To be honest, purely as a user, I would probably prefer something like
> below:
> Selected by [y/m]:
> - EXPR_01
> - EXPR_02
> Selected by [n]:
> - EXPR_03
> - EXPR_04
Sorting again, just with header? It looks more readable (although Masahiro's approach is
quite readable as well). If you chose this, I'd suggest not displaying title, when there
is empty list. i.e., don't show "Selected by [y/m]" in this:
Selected by [y/m]:
Selected by [n]:
- EXPR_03
- EXPR_04
> But (as a developer) I feel it can only come at the price of increased
> complexity of __expr_print() (at least, if not bigger than, [1]). What I
> like about the current approach suggested by Masahiro is that it keeps
> the impact low with still making a great improvement in readability.
> If you think we should explore the second possibility of grouping the
> active/inactive dependencies, I'll try to come up with some solution
> in the next days.
> [1] https://marc.info/?l=linux-kbuild&m=151777006005199&w=4
Kind regards,
Petr
next prev parent reply other threads:[~2018-02-14 0:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 0:56 [PATCH 1/2] kconfig: Print reverse dependencies on new line consistently Eugeniu Rosca
2018-02-13 0:56 ` [PATCH 2/2] kconfig: Print the value of each reverse dependency Eugeniu Rosca
2018-02-13 6:18 ` Ulf Magnusson
2018-02-13 23:54 ` Eugeniu Rosca
2018-02-14 0:41 ` Petr Vorel [this message]
2018-02-17 17:26 ` Eugeniu Rosca
2018-02-14 4:09 ` Ulf Magnusson
2018-02-17 17:20 ` Eugeniu Rosca
2018-02-17 17:31 ` Ulf Magnusson
2018-02-18 11:34 ` Eugeniu Rosca
2018-02-14 0:46 ` Petr Vorel
2018-02-13 6:11 ` [PATCH 1/2] kconfig: Print reverse dependencies on new line consistently Ulf Magnusson
2018-02-13 6:40 ` Petr Vorel
2018-02-14 0:32 ` Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214004153.GA1154@x230 \
--to=petr.vorel@gmail.com \
--cc=erosca@de.adit-jv.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=pebolle@tiscali.nl \
--cc=rdunlap@infradead.org \
--cc=rosca.eugeniu@gmail.com \
--cc=roscaeugeniu@gmail.com \
--cc=ulfalizer@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox