public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Eugeniu Rosca <roscaeugeniu@gmail.com>
To: Ulf Magnusson <ulfalizer@gmail.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Nicolas Pitre <nicolas.pitre@linaro.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Petr Vorel <petr.vorel@gmail.com>,
	Paul Bolle <pebolle@tiscali.nl>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Eugeniu Rosca <rosca.eugeniu@gmail.com>,
	Eugeniu Rosca <erosca@de.adit-jv.com>
Subject: Re: [PATCH 2/2] kconfig: Print the value of each reverse dependency
Date: Sat, 17 Feb 2018 18:20:59 +0100	[thread overview]
Message-ID: <20180217172059.GA16512@example.com> (raw)
In-Reply-To: <CAFkk2KTtvHPtSXWX83aVaXpixU7CukG==NvwXDGmHbg0=1sC8Q@mail.gmail.com>

Hi Ulf,

On Wed, Feb 14, 2018 at 05:09:50AM +0100, Ulf Magnusson wrote:
> IMO, we could take this as is (after addressing other people's
> comments), since it's already a big improvement, and then add sorting
> later if we feel like it.
> 
> Don't have to do everything at once. :)

I agree that it's not possible to do everything perfect right from the
start. But since we are changing the user experience, I just thought
that we would first like to see how both implementations (prefixed
vs grouped tokens) look like, then make a decision (I'm still open
minded about it), then affect the users.

> 
> Think it should be pretty straightforward to add the kind of sorting
> you had in mind at least, by changing PRINT_ALL_SELECTS into
> PRINT_INACTIVE_SELECTS in [1], and tweaking some conditions.

Yep. Thanks to your support, I've pushed v3, where you've already
provided your review findings, which I'm going to fix soon :)

Thanks,
Eugeniu.

  reply	other threads:[~2018-02-17 17:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13  0:56 [PATCH 1/2] kconfig: Print reverse dependencies on new line consistently Eugeniu Rosca
2018-02-13  0:56 ` [PATCH 2/2] kconfig: Print the value of each reverse dependency Eugeniu Rosca
2018-02-13  6:18   ` Ulf Magnusson
2018-02-13 23:54     ` Eugeniu Rosca
2018-02-14  0:41       ` Petr Vorel
2018-02-17 17:26         ` Eugeniu Rosca
2018-02-14  4:09       ` Ulf Magnusson
2018-02-17 17:20         ` Eugeniu Rosca [this message]
2018-02-17 17:31           ` Ulf Magnusson
2018-02-18 11:34             ` Eugeniu Rosca
2018-02-14  0:46   ` Petr Vorel
2018-02-13  6:11 ` [PATCH 1/2] kconfig: Print reverse dependencies on new line consistently Ulf Magnusson
2018-02-13  6:40   ` Petr Vorel
2018-02-14  0:32     ` Eugeniu Rosca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180217172059.GA16512@example.com \
    --to=roscaeugeniu@gmail.com \
    --cc=erosca@de.adit-jv.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=pebolle@tiscali.nl \
    --cc=petr.vorel@gmail.com \
    --cc=rdunlap@infradead.org \
    --cc=rosca.eugeniu@gmail.com \
    --cc=ulfalizer@gmail.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox