Re: [PATCH 2/2] kconfig: Print the value of each reverse dependency

Petr Vorel
2018-02-14T00:41:59Z

Hi Eugeniu,

> To be honest, purely as a user, I would probably prefer something like
> below:

> Selected by [y/m]:
> - EXPR_01
> - EXPR_02
> Selected by [n]:
> - EXPR_03
> - EXPR_04
Sorting again, just with header? It looks more readable (although Masahiro's approach is
quite readable as well). If you chose this, I'd suggest not displaying title, when there
is empty list. i.e., don't show "Selected by [y/m]" in this:
Selected by [y/m]:
Selected by [n]:
- EXPR_03
- EXPR_04

> But (as a developer) I feel it can only come at the price of increased
> complexity of __expr_print() (at least, if not bigger than, [1]). What I
> like about the current approach suggested by Masahiro is that it keeps
> the impact low with still making a great improvement in readability.

> If you think we should explore the second possibility of grouping the
> active/inactive dependencies, I'll try to come up with some solution
> in the next days.

> [1] https://marc.info/?l=linux-kbuild&m=151777006005199&w=4

Kind regards,
Petr