public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: linux-kbuild@vger.kernel.org,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>
Subject: Re: [PATCH 2/2] kbuild: rename built-in.o to built-in.a
Date: Sun, 18 Feb 2018 18:10:05 +0100	[thread overview]
Message-ID: <20180218171005.GA20286@ravnborg.org> (raw)
In-Reply-To: <20180210142504.29890-3-npiggin@gmail.com>

Hi Nicholas.

On Sun, Feb 11, 2018 at 12:25:04AM +1000, Nicholas Piggin wrote:
> Incremental linking is gone, so rename built-in.o to built-in.a, which
> is the usual extension for archive files.
> 
> This patch does two things, first is a simple search/replace:
> 
> git grep -l 'built-in\.o' | xargs sed -i 's/built-in\.o/built-in\.a/g'
> 
> The second is to invert nesting of nested text manipulations to avoid
> filtering built-in.a out from libs-y2:
> 
> -libs-y2 := $(filter-out %.a, $(patsubst %/, %/built-in.a, $(libs-y)))
> +libs-y2 := $(patsubst %/, %/built-in.a, $(filter-out %.a, $(libs-y)))
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>

Renaming is welcome - .o files should not list files.
Acked-by: Sam Ravnborg <sam@ravnborg.org>

Did you check that make clean / make mrproper continue to
do the right thing?

I recalled we had "*.o" hardcoded somewhere but grep
did not reveal any places that should matter.
So likely it does.

	Sam

  parent reply	other threads:[~2018-02-18 17:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-10 14:25 [PATCH 0/2] remove the last of incremental linking Nicholas Piggin
2018-02-10 14:25 ` [PATCH 1/2] kbuild: remove incremental linking option Nicholas Piggin
2018-02-11  6:04   ` Masahiro Yamada
2018-02-18 14:26     ` Sam Ravnborg
2018-02-18 16:53       ` Nicholas Piggin
2018-02-10 14:25 ` [PATCH 2/2] kbuild: rename built-in.o to built-in.a Nicholas Piggin
2018-02-11  4:38   ` Masahiro Yamada
2018-02-11 11:15     ` Nicholas Piggin
2018-02-12  0:57       ` Masahiro Yamada
2018-02-12  1:26         ` Nicolas Pitre
2018-02-12  3:00           ` Masahiro Yamada
2018-02-12  3:08             ` Masahiro Yamada
2018-02-18 17:10   ` Sam Ravnborg [this message]
2018-02-19  7:04     ` Nicholas Piggin
2018-02-18 23:42 ` [PATCH 0/2] remove the last of incremental linking Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180218171005.GA20286@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=npiggin@gmail.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox