From: Sam Ravnborg <sam@ravnborg.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org,
Michal Marek <michal.lkml@markovi.net>,
Ulf Magnusson <ulfalizer@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
"Luis R . Rodriguez" <mcgrof@kernel.org>,
linux-kernel@vger.kernel.org,
Marc Herbert <marc.herbert@intel.com>
Subject: Re: [PATCH 1/2] kconfig: remove check_stdin()
Date: Sun, 18 Feb 2018 20:44:33 +0100 [thread overview]
Message-ID: <20180218194433.GB29324@ravnborg.org> (raw)
In-Reply-To: <1518069400-7037-1-git-send-email-yamada.masahiro@socionext.com>
On Thu, Feb 08, 2018 at 02:56:39PM +0900, Masahiro Yamada wrote:
> Except silentoldconfig, valid_stdin is 1, so check_stdin() is no-op.
>
> oldconfig and silentoldconfig work almost in the same way except that
> the latter generates additional files. Both ask users for input for
> new symbols.
>
> I do not know why only silentoldconfig requires stdio be tty.
The general idea was to error out if stdout was not a tty and
kconfig wanted to prompt the user for anything.
So we avoided having a kconfig that would hang waiting for
user inputs when the user could not see that anything was prompted for.
The actual implementation may not follow this today as many seems not
to be aware of this little trick.
Sam
prev parent reply other threads:[~2018-02-18 19:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 5:56 [PATCH 1/2] kconfig: remove check_stdin() Masahiro Yamada
2018-02-08 5:56 ` [PATCH 2/2] kconfig: echo stdin to stdout if either is redirected Masahiro Yamada
2018-02-08 6:35 ` Ulf Magnusson
2018-02-08 6:51 ` Ulf Magnusson
2018-02-08 6:53 ` Masahiro Yamada
2018-02-08 7:05 ` Ulf Magnusson
2018-02-08 6:21 ` [PATCH 1/2] kconfig: remove check_stdin() Ulf Magnusson
2018-02-18 19:44 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180218194433.GB29324@ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.herbert@intel.com \
--cc=mcgrof@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=rdunlap@infradead.org \
--cc=ulfalizer@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox