From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from asavdk3.altibox.net ([109.247.116.14]:44624 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751383AbeBRToh (ORCPT ); Sun, 18 Feb 2018 14:44:37 -0500 Date: Sun, 18 Feb 2018 20:44:33 +0100 From: Sam Ravnborg Subject: Re: [PATCH 1/2] kconfig: remove check_stdin() Message-ID: <20180218194433.GB29324@ravnborg.org> References: <1518069400-7037-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1518069400-7037-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Michal Marek , Ulf Magnusson , Randy Dunlap , "Luis R . Rodriguez" , linux-kernel@vger.kernel.org, Marc Herbert On Thu, Feb 08, 2018 at 02:56:39PM +0900, Masahiro Yamada wrote: > Except silentoldconfig, valid_stdin is 1, so check_stdin() is no-op. > > oldconfig and silentoldconfig work almost in the same way except that > the latter generates additional files. Both ask users for input for > new symbols. > > I do not know why only silentoldconfig requires stdio be tty. The general idea was to error out if stdout was not a tty and kconfig wanted to prompt the user for anything. So we avoided having a kconfig that would hang waiting for user inputs when the user could not see that anything was prompted for. The actual implementation may not follow this today as many seems not to be aware of this little trick. Sam