From: Laura Abbott <labbott@redhat.com>
To: Andy Lutomirski <luto@kernel.org>,
mjw@fedoraproject.org, "H . J . Lu" <hjl.tools@gmail.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Laura Abbott <labbott@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
X86 ML <x86@kernel.org>,
linux-kernel@vger.kernel.org, Nick Clifton <nickc@redhat.com>,
Cary Coutant <ccoutant@gmail.com>,
linux-kbuild@vger.kernel.org
Subject: [RFCv2 PATCH 0/3] Salted build ids via linker sections
Date: Thu, 29 Mar 2018 11:01:09 -0700 [thread overview]
Message-ID: <20180329180112.11055-1-labbott@redhat.com> (raw)
Hi,
This is v2 of my proposal to allow unique build-ids in the kernel. from
last time:
""
In Fedora, the debug information is packaged separately (foo-debuginfo) and
can be installed separately. There's been a long standing issue where only one
version of a debuginfo info package can be installed at a time. Mark Wielaard
made an effort for Fedora 27 to allow parallel installation of debuginfo (see
https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo for
more details)
Part of the requirement to allow this to work is that build ids are
unique between builds. The existing upstream rpm implementation ensures
this by re-calculating the build-id using the version and release as a
seed. This doesn't work 100% for the kernel because of the vDSO which is
its own binary and doesn't get updated. After poking holes in a few of my
ideas, there was a discussion with some people from the binutils team about
adding --build-id-salt to let ld do the calculation debugedit is doing. There
was a counter proposal made about adding some extra information via a .comment
which will affect the build id calculation but just get stripped out.
""
This v2 cleans up the naming to be consistent and also switches to a
config option vs. an environment variable. I've seen some sporadic
failures about missing the generated header so I think I'm still missing
a dependency somewhere. I'm still mostly looking for feedback whether
this would be acceptable for merging or if we should just persue a
--build-id-salt in binutils.
Thanks,
Laura
Laura Abbott (3):
kbuild: Introduce build-salt generated header
kbuild: Link with generated build-salt header
x86/vdso: Add build salt to the vDSO
Makefile | 13 +++++++++++--
arch/x86/entry/vdso/vdso-layout.lds.S | 3 +++
init/Kconfig | 8 ++++++++
scripts/.gitignore | 1 +
scripts/Makefile | 2 +-
scripts/build-salt.lds.S | 5 +++++
scripts/gensalt | 21 +++++++++++++++++++++
scripts/link-vmlinux.sh | 3 ++-
8 files changed, 52 insertions(+), 4 deletions(-)
create mode 100644 scripts/build-salt.lds.S
create mode 100755 scripts/gensalt
--
2.16.2
next reply other threads:[~2018-03-29 18:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 18:01 Laura Abbott [this message]
2018-03-29 18:01 ` [RFCv2 PATCH 1/3] kbuild: Introduce build-salt generated header Laura Abbott
2018-03-29 18:01 ` [RFCv2 PATCH 2/3] kbuild: Link with generated build-salt header Laura Abbott
2018-05-07 6:38 ` Masahiro Yamada
2018-03-29 18:01 ` [RFCv2 PATCH 3/3] x86/vdso: Add build salt to the vDSO Laura Abbott
2018-05-07 6:42 ` Masahiro Yamada
2018-03-30 12:40 ` [RFCv2 PATCH 0/3] Salted build ids via linker sections Mark Wielaard
2018-05-07 6:58 ` Masahiro Yamada
2018-05-08 2:49 ` Andy Lutomirski
2018-05-14 20:51 ` Laura Abbott
2018-05-07 6:28 ` Masahiro Yamada
2018-05-14 21:02 ` Laura Abbott
2018-05-17 8:37 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329180112.11055-1-labbott@redhat.com \
--to=labbott@redhat.com \
--cc=ccoutant@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mjw@fedoraproject.org \
--cc=nickc@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox