From: Kevin Locke <kevin@kevinlocke.name>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kbuild@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Andrei Vagin <avagin@virtuozzo.com>
Subject: Re: [PATCH] kconfig: fix localmodconfig
Date: Fri, 8 Jun 2018 23:25:08 -0600 [thread overview]
Message-ID: <20180609052508.GA10667@kevinolos> (raw)
In-Reply-To: <20180608215338.GA28473@ravnborg.org>
On Fri, 2018-06-08 at 23:53 +0200, Sam Ravnborg wrote:
> When kconfig syntax moved to use $(FOO) for environment variables
> localmodconfig was not updated.
> Fix so it now works with the new syntax $(FOO)
>
> Fixes: 104daea149c45cc84842ce77a9bd6436d19f3dd8 ("kconfig: reference environment variables directly and remove 'option env='")
I can confirm `make localmodconfig` from 104daea149c4 with this patch
applied creates the same .config as it did in 104daea149c4^ and that
it creates a plausible .config (which I haven't built/tested yet) when
applied to master.
Works for me. Thanks for the very fast fix!
Tested-by: Kevin Locke <kevin@kevinlocke.name>
Cheers,
Kevin
next prev parent reply other threads:[~2018-06-09 5:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 21:53 [PATCH] kconfig: fix localmodconfig Sam Ravnborg
2018-06-09 5:25 ` Kevin Locke [this message]
2018-06-10 13:29 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180609052508.GA10667@kevinolos \
--to=kevin@kevinlocke.name \
--cc=avagin@virtuozzo.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox