From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from asavdk3.altibox.net ([109.247.116.14]:56920 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935302AbeFMUgT (ORCPT ); Wed, 13 Jun 2018 16:36:19 -0400 Date: Wed, 13 Jun 2018 22:36:14 +0200 From: Sam Ravnborg Subject: Re: [PATCH v4 1/9] Makefile: Prepare for using macros for inline asm Message-ID: <20180613203614.GB10472@ravnborg.org> References: <20180612115050.185112-1-namit@vmware.com> <20180612115050.185112-2-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Masahiro Yamada Cc: Nadav Amit , Linux Kernel Mailing List , X86 ML , Michal Marek , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Linux Kbuild mailing list > > > +macros: $(obj)/macros.s > > + @: > > If you add a phony target, it should be added to 'PHONY'. Or this part: > +archmacros: > + $(Q)$(MAKE) $(build)=arch/x86/kernel macros could be modified to specify the exact filename so this indirection is not needed. PS. Only one file posted to kbuild, so impossible to review as context is missing. Sam