* [PATCH 0/4] Adds -Wshadow=local on KBUILD_HOSTCFLAGS
@ 2018-10-17 0:07 Leonardo Brás
2018-10-17 4:45 ` [Lkcamp] " Helen Koike
0 siblings, 1 reply; 2+ messages in thread
From: Leonardo Brás @ 2018-10-17 0:07 UTC (permalink / raw)
To: lkcamp
Cc: Matthew Wilcox, Andy Lutomirski, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H. Peter Anvin, x86, Masahiro Yamada,
Michal Marek, linux-kernel, linux-kbuild
This patchset add -Wshadow=local on KBUILD_HOSTCFLAGS and fixes
all code that show this warning.
The third patch was already submitted, but was not merged yet.
I like to think it's part of this patchset, but if it was
already merged, please ignore it.
Leonardo Brás (4):
Adds -Wshadow=local on KBUILD_HOSTCFLAGS
Renames variable to fix shadow warning.
kbuild: Removes unnecessary shadowed local variable and optimize
testing.
Changes macro usage to avoid shadowing a variable.
Makefile | 2 +-
arch/x86/entry/vdso/vdso2c.h | 4 ++--
scripts/asn1_compiler.c | 7 +++----
scripts/mod/file2alias.c | 14 ++++++++------
4 files changed, 14 insertions(+), 13 deletions(-)
--
2.19.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [Lkcamp] [PATCH 0/4] Adds -Wshadow=local on KBUILD_HOSTCFLAGS
2018-10-17 0:07 [PATCH 0/4] Adds -Wshadow=local on KBUILD_HOSTCFLAGS Leonardo Brás
@ 2018-10-17 4:45 ` Helen Koike
0 siblings, 0 replies; 2+ messages in thread
From: Helen Koike @ 2018-10-17 4:45 UTC (permalink / raw)
To: Leonardo Brás, lkcamp
Cc: x86, linux-kbuild, Matthew Wilcox, linux-kernel, Masahiro Yamada,
Ingo Molnar, Borislav Petkov, Andy Lutomirski, H. Peter Anvin,
Michal Marek, Thomas Gleixner
Hi Leonardo,
Thanks for the patches.
On 10/16/18 9:07 PM, Leonardo Brás wrote:
> This patchset add -Wshadow=local on KBUILD_HOSTCFLAGS and fixes
> all code that show this warning.
>
> The third patch was already submitted, but was not merged yet.
> I like to think it's part of this patchset, but if it was
> already merged, please ignore it.
You can check if it was merged in the maintainers' tree, if it is not
there then it is not merged :)
imho, I would prefer if you submitted it as a v2 with an explanation of
what changed since v1 (e.g. new commits) or even stating that nothing
has changed and you just regrouped it.
Or better, you could also not re-submit it and just point out that this
series depends on a previous commit (with a link to it).
>
> Leonardo Brás (4):
> Adds -Wshadow=local on KBUILD_HOSTCFLAGS
> Renames variable to fix shadow warning.
> kbuild: Removes unnecessary shadowed local variable and optimize
> testing.
> Changes macro usage to avoid shadowing a variable.
>
> Makefile | 2 +-
> arch/x86/entry/vdso/vdso2c.h | 4 ++--
> scripts/asn1_compiler.c | 7 +++----
> scripts/mod/file2alias.c | 14 ++++++++------
> 4 files changed, 14 insertions(+), 13 deletions(-)
>
I hope this helps.
Regards,
Helen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-17 12:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-17 0:07 [PATCH 0/4] Adds -Wshadow=local on KBUILD_HOSTCFLAGS Leonardo Brás
2018-10-17 4:45 ` [Lkcamp] " Helen Koike
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox