From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.skyhub.de ([5.9.137.197]:39734 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727360AbeJRRQr (ORCPT ); Thu, 18 Oct 2018 13:16:47 -0400 Date: Thu, 18 Oct 2018 11:16:07 +0200 From: Borislav Petkov Subject: Re: [PATCH 1/4] Adds -Wshadow=local on KBUILD_HOSTCFLAGS Message-ID: <20181018091606.GA20831@zn.tnic> References: <20181017000809.GA21292@WindFlash> <20181017081115.GA22535@zn.tnic> <20181017083126.GB22535@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Leonardo Bras Cc: Masahiro Yamada , lkcamp@lists.libreplanetbr.org, Matthew Wilcox , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Michal Marek , linux-kernel , linux-kbuild@vger.kernel.org On Wed, Oct 17, 2018 at 09:40:53PM -0300, Leonardo Bras wrote: > The idea was to put it as default and fix all the shadowing warnings. > What do you think? I am open to suggestions. That's Masahiro's call. In the rest of the kernel, those warnings are behind the W=2 switch - i.e., not enabled by default. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.