From: Sam Ravnborg <sam@ravnborg.org>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
Jim Wilson <jimw@sifive.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>
Subject: Re: [PATCH 0/2] modpost: skip section mismatch warnings on ELF local symbols by default
Date: Sat, 20 Oct 2018 16:08:35 +0200 [thread overview]
Message-ID: <20181020140835.GA3351@ravnborg.org> (raw)
In-Reply-To: <20181020131911.22443-1-paul.walmsley@sifive.com>
Hi Paul.
> modpost: skip section mismatch warnings on ELF local symbols by default
>
> modpost, by default, reports section mismatch warnings on ELF local
> symbols. This caused false positive warnings to be reported for a
> local symbol name that would otherwise be elided by matching against a
> name pattern. This was observed using a RISC-V toolchain that generates
> section anchors.
>
> To avoid this noise in the common case, this patch series disables
> section mismatch warnings on ELF local symbols by default.
This part is fine.
> It also
> adds a modpost command line switch to re-enable these warnings, since
> I wasn't able to convince myself that section mismatch warnings on ELF
> local symbols were completely useless; just mostly useless :-)
modpost is not supposed to be used outside the kernel build.
And therefore if we introduce a new option then the infrastructure
to enable that option should also be in place.
In this particular case I cannot see why we should add the possibility
to include local symbols, in other words do not add the option.
Wait a few days before you kill it, maybe others see the usefulness of it.
I checked if there were any options supported by modpost that
was not configurable in makefile.modpost.
And I could see that the -M and -K options in getopt() was leftovers.
The code that used these option was was dropped in:
a8773769d1a1e08d0ca15f890515401ab3860637 ("Kbuild: clear marker out of modpost")
Could you add a patch that delete these on top of what you already have.
Sam
next prev parent reply other threads:[~2018-10-20 22:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-20 13:19 [PATCH 0/2] modpost: skip section mismatch warnings on ELF local symbols by default Paul Walmsley
2018-10-20 13:19 ` [PATCH 1/2] modpost: add switch to skip symbol exclusions likely to generate false positives Paul Walmsley
2018-10-20 13:19 ` [PATCH 2/2] modpost: skip ELF local symbols by default during section mismatch check Paul Walmsley
2018-11-13 2:19 ` Masahiro Yamada
2018-11-14 19:30 ` Paul Walmsley
2018-10-20 14:08 ` Sam Ravnborg [this message]
2018-11-15 0:48 ` [PATCH 0/2] modpost: skip section mismatch warnings on ELF local symbols by default Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181020140835.GA3351@ravnborg.org \
--to=sam@ravnborg.org \
--cc=jimw@sifive.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michal.lkml@markovi.net \
--cc=paul.walmsley@sifive.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox