From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:32928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725895AbeJ2Cyu (ORCPT ); Sun, 28 Oct 2018 22:54:50 -0400 Date: Sun, 28 Oct 2018 14:09:11 -0400 From: Steven Rostedt Subject: Re: [PATCH v3 1/4] x86/mm: declare check_la57_support() as inline Message-ID: <20181028140911.21d49629@vmware.local.home> In-Reply-To: <20181028130945.23581-2-changbin.du@gmail.com> References: <20181028130945.23581-1-changbin.du@gmail.com> <20181028130945.23581-2-changbin.du@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Changbin Du Cc: yamada.masahiro@socionext.com, michal.lkml@markovi.net, tglx@linutronix.de, mingo@redhat.com, linux@armlinux.org.uk, akpm@linux-foundation.org, gregkh@linuxfoundation.org, x86@kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sparse@vger.kernel.org, robin.murphy@arm.com On Sun, 28 Oct 2018 13:09:42 +0000 Changbin Du wrote: > The level4_kernel_pgt is only defined when X86_5LEVEL is enabled. > So declare check_la57_support() as inline to make sure the code > referring to level4_kernel_pgt is optimized out. This is a preparation > for CONFIG_CC_OPTIMIZE_FOR_DEBUGGING. > > Signed-off-by: Changbin Du Reviewed-by: Steven Rostedt (VMware) -- Steve > Cc: Masahiro Yamada > --- > arch/x86/kernel/head64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c > index 5dc377dc9d7b..5ae682f2aa83 100644 > --- a/arch/x86/kernel/head64.c > +++ b/arch/x86/kernel/head64.c > @@ -98,7 +98,7 @@ static bool __head check_la57_support(unsigned long physaddr) > return true; > } > #else > -static bool __head check_la57_support(unsigned long physaddr) > +static inline bool __head check_la57_support(unsigned long physaddr) > { > return false; > }