Re: [PATCH 1/1] merge_config.sh: Replace prefix CONFIG_ with any prefix

[Petr Vorel <petr.vorel@gmail.com>]

Hi Masahiro,

> Please send v2 with the commit log properly filled.
OK I'll do.

> I will take my credit as Suggested-by.
Sure :).

> > > +# Check the environment variable "CONFIG_" for the config option prefix.
> > > +# If unset, the default is "CONFIG_".
> > > +: ${CONFIG_=CONFIG_}
> > Although I guess this could be less cryptic:
> > CONFIG_="${CONFIG_:-CONFIG_}"

> You should not use the colon
> because we want to allow the environment variable
> 'CONFIG_' being set as empty.
How about having default 'CONFIG_' and if it's empty change it to
'[A-Z0-9_]\+' ? I know, it's different from C definition in lkc.h, but IMHO it'd
make sense. But I guess you prefer your suggestion CONFIG_PREFIX=${CONFIG_-CONFIG_}

> In fact, Buildroot uses empty prefix instead of "BR2_".
> In my understanding, Buildroot just has a convention where
> symbols in Config.in files start with "BR2_".
IMHO buildroot uses 'BR2_' prefix. That's what we want to use with
merge_config.sh.


Kind regards,
Petr