Re: [kbuild-all] [kbuild:kbuild 2/4] arch/openrisc/include/asm/spr.h:20:27: error: impossible constraint in 'asm'

From: Changbin Du <changbin.du@gmail.com>
To: Stafford Horne <shorne@gmail.com>
Cc: kbuild test robot <lkp@intel.com>,
	Changbin Du <changbin.du@gmail.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	kbuild-all@01.org, linux-kbuild@vger.kernel.org
Subject: Re: [kbuild-all] [kbuild:kbuild 2/4] arch/openrisc/include/asm/spr.h:20:27: error: impossible constraint in 'asm'
Date: Mon, 12 Nov 2018 22:36:06 +0800	[thread overview]
Message-ID: <20181112143605.a6evj3jrsnwpnush@mail.google.com> (raw)
In-Reply-To: <CAAfxs76m4uk0VDah1AsMQMxtKUimc7LFKcuEGMtQbEQ_1xw9gQ@mail.gmail.com>

On Mon, Nov 12, 2018 at 06:51:57AM +0900, Stafford Horne wrote:
> Again, in plain text mode:
> 
> Did something change with the compiler setup?  The error here says gcc
> 6.0.0.  however the version in the make.cross tool is 5.4.0, which is
> strange.  Fyi, We have binaries for 7.2.0 and 9.x which can be used.
> 
> Also our toolchain is all upstream as of last week.
> 
> On Mon, Nov 12, 2018 at 6:03 AM Stafford Horne <shorne@gmail.com> wrote:
> >
> > Hello,
> >
> > Did something change with the compiler setup?  The error here says gcc 6.0.0.  however the version in the make.cross tool is 5.4.0, which is strange.  Fyi, We have binaries for 7.2.0 and 9.x which can be used.
> >
> > Also our toolchain is all upstream as of last week.
> >
> > -stafford
> >
I added a patch which disables gcc auto-inlining by '-fno-inline-functions 
-fno-inline-small-functions -fno-inline-functions-called-once' (but default
option is false).

See series https://lkml.org/lkml/2018/5/9/213.

I am trying to make gcc happy for this corner case. Thanks!

> > On Mon, Nov 12, 2018, 3:17 AM kbuild test robot <lkp@intel.com wrote:
> >>
> >> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git kbuild
> >> head:   e73c4f947acbe6ff12d1f1711d6a8c0ad1c9483a
> >> commit: cc2b86bb90b2d045b82d45a6dbe7c9285e0f00b9 [2/4] kernel hacking: add a config option to disable compiler auto-inlining
> >> config: openrisc-allyesconfig (attached as .config)
> >> compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
> >> reproduce:
> >>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >>         chmod +x ~/bin/make.cross
> >>         git checkout cc2b86bb90b2d045b82d45a6dbe7c9285e0f00b9
> >>         # save the attached .config to linux build tree
> >>         make.cross ARCH=openrisc
> >>
> >> All errors (new ones prefixed by >>):
> >>
> >>    In file included from arch/openrisc/mm/cache.c:17:0:
> >>    arch/openrisc/mm/cache.c: In function 'cache_loop':
> >>    arch/openrisc/include/asm/spr.h:20:27: warning: asm operand 0 probably doesn't match constraints
> >>     #define mtspr(_spr, _val) __asm__ __volatile__ (  \
> >>                               ^
> >>    arch/openrisc/mm/cache.c:29:3: note: in expansion of macro 'mtspr'
> >>       mtspr(reg, line);
> >>       ^~~~~
> >> >> arch/openrisc/include/asm/spr.h:20:27: error: impossible constraint in 'asm'
> >>     #define mtspr(_spr, _val) __asm__ __volatile__ (  \
> >>                               ^
> >>    arch/openrisc/mm/cache.c:29:3: note: in expansion of macro 'mtspr'
> >>       mtspr(reg, line);
> >>       ^~~~~
> >>
> >> vim +/asm +20 arch/openrisc/include/asm/spr.h
> >>
> >> 58e0166a4 Jonas Bonn 2011-06-04  19
> >> 58e0166a4 Jonas Bonn 2011-06-04 @20  #define mtspr(_spr, _val) __asm__ __volatile__ (           \
> >> 58e0166a4 Jonas Bonn 2011-06-04  21     "l.mtspr r0,%1,%0"                                      \
> >> 58e0166a4 Jonas Bonn 2011-06-04  22     : : "K" (_spr), "r" (_val))
> >> 58e0166a4 Jonas Bonn 2011-06-04  23  #define mtspr_off(_spr, _off, _val) __asm__ __volatile__ ( \
> >> 58e0166a4 Jonas Bonn 2011-06-04  24     "l.mtspr %0,%1,%2"                                      \
> >> 58e0166a4 Jonas Bonn 2011-06-04  25     : : "r" (_off), "r" (_val), "K" (_spr))
> >> 58e0166a4 Jonas Bonn 2011-06-04  26
> >>
> >> :::::: The code at line 20 was first introduced by commit
> >> :::::: 58e0166a4772aaeb10c9b0f6d59f19099d2047df OpenRISC: Headers
> >>
> >> :::::: TO: Jonas Bonn <jonas@southpole.se>
> >> :::::: CC: Jonas Bonn <jonas@southpole.se>
> >>
> >> ---
> >> 0-DAY kernel test infrastructure                Open Source Technology Center
> >> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> >> _______________________________________________
> >> kbuild-all mailing list
> >> kbuild-all@lists.01.org
> >> https://lists.01.org/mailman/listinfo/kbuild-all

-- 
Cheers,
Changbin Du