From: Peter Zijlstra <peterz@infradead.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Richard Biener <rguenther@suse.de>,
Nadav Amit <namit@vmware.com>,
Logan Gunthorpe <logang@deltatee.com>,
Sedat Dilek <sedat.dilek@gmail.com>,
Segher Boessenkool <segher@kernel.crashing.org>,
linux-arch@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Michal Marek <michal.lkml@markovi.net>,
linux-sparse@vger.kernel.org, Alok Kataria <akataria@vmware.com>,
Juergen Gross <jgross@suse.com>,
Andy Lutomirski <luto@kernel.org>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kbuild, x86: revert macros in extended asm workarounds
Date: Thu, 13 Dec 2018 11:51:46 +0100 [thread overview]
Message-ID: <20181213105146.GH5289@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1544692661-9455-1-git-send-email-yamada.masahiro@socionext.com>
On Thu, Dec 13, 2018 at 06:17:41PM +0900, Masahiro Yamada wrote:
> Revert the following commits:
>
> - 5bdcd510c2ac9efaf55c4cbd8d46421d8e2320cd
> ("x86/jump-labels: Macrofy inline assembly code to work around GCC inlining bugs")
>
> - d5a581d84ae6b8a4a740464b80d8d9cf1e7947b2
> ("x86/cpufeature: Macrofy inline assembly code to work around GCC inlining bugs")
>
> - 0474d5d9d2f7f3b11262f7bf87d0e7314ead9200.
> ("x86/extable: Macrofy inline assembly code to work around GCC inlining bugs")
>
> - 494b5168f2de009eb80f198f668da374295098dd.
> ("x86/paravirt: Work around GCC inlining bugs when compiling paravirt ops")
>
> - f81f8ad56fd1c7b99b2ed1c314527f7d9ac447c6.
> ("x86/bug: Macrofy the BUG table section handling, to work around GCC inlining bugs")
>
> - 77f48ec28e4ccff94d2e5f4260a83ac27a7f3099.
> ("x86/alternatives: Macrofy lock prefixes to work around GCC inlining bugs")
>
> - 9e1725b410594911cc5981b6c7b4cea4ec054ca8.
> ("x86/refcount: Work around GCC inlining bug")
> (Conflicts: arch/x86/include/asm/refcount.h)
>
> - c06c4d8090513f2974dfdbed2ac98634357ac475.
> ("x86/objtool: Use asm macros to work around GCC inlining bugs")
>
> - 77b0bf55bc675233d22cd5df97605d516d64525e.
> ("kbuild/Makefile: Prepare for using macros in inline assembly code to work around asm() related GCC inlining bugs")
>
I don't think we want to blindly revert all that. Some of them actually
made sense and did clean up things irrespective of the asm-inline issue.
In particular I like the jump-label one. The cpufeature one OTOh, yeah,
I'd love to get that reverted.
And as a note; the normal commit quoting style is:
d5a581d84ae6 ("x86/cpufeature: Macrofy inline assembly code to work around GCC inlining bugs")
next prev parent reply other threads:[~2018-12-13 10:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 9:17 [PATCH] kbuild, x86: revert macros in extended asm workarounds Masahiro Yamada
2018-12-13 10:51 ` Peter Zijlstra [this message]
2018-12-15 0:51 ` Masahiro Yamada
2018-12-16 2:33 ` Nadav Amit
2018-12-16 10:00 ` Borislav Petkov
2018-12-17 1:00 ` Nadav Amit
2018-12-17 9:16 ` Sedat Dilek
2018-12-18 19:33 ` Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213105146.GH5289@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akataria@vmware.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=luc.vanoostenryck@gmail.com \
--cc=luto@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mingo@redhat.com \
--cc=namit@vmware.com \
--cc=rguenther@suse.de \
--cc=sedat.dilek@gmail.com \
--cc=segher@kernel.crashing.org \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox