From: Sasha Levin <sashal@kernel.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Ivan Babrou <ivan@cloudflare.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
kernel-team <kernel-team@cloudflare.com>,
stable <stable@vger.kernel.org>
Subject: Re: syncconfig changes in 4.19.34 break builds
Date: Thu, 11 Apr 2019 09:47:49 -0400 [thread overview]
Message-ID: <20190411134749.GH11568@sasha-vm> (raw)
In-Reply-To: <CAK7LNATvZ_baJDr2SeoaUc6Of2sLz=MHMB=MDzQ1eNMcgjUW=A@mail.gmail.com>
On Thu, Apr 11, 2019 at 01:27:43PM +0900, Masahiro Yamada wrote:
>Hi Sasha,
>
>On Wed, Apr 10, 2019 at 12:39 AM Sasha Levin <sashal@kernel.org> wrote:
>>
>> On Tue, Apr 09, 2019 at 02:50:04PM +0900, Masahiro Yamada wrote:
>> >Greg, Sasha,
>> >
>> >
>> >Sorry, the commit ID was wrong.
>> >
>> >
>> >The following commit for 4.19.x:
>> >
>> >commit 02826a6ba301b72461c3706e1cc66d5571cd327e
>> >Author: Masahiro Yamada <yamada.masahiro@socionext.com>
>> >Date: Mon Nov 5 16:52:34 2018 +0900
>> >
>> > kbuild: deb-pkg: fix bindeb-pkg breakage when O= is used
>>
>> This commit claims it's fixing 80463f1b7bf9, which is not in 4.19. Was
>> that a mistake in the commit message?
>
>No. The commit message is correct.
>The Fixes: tag points to the first bad commit in _upstream_.
>
>
>What I want to say is:
>638ecaf58369 [which was 9390dff66a5 in upstream]
>depends on 02826a6ba301b, which is missing in v4.19.x branch.
>
>638ecaf58369 was cherry-picked without correct patch
>dependency, so it got broken. That's all.
>
>
>There are two options to fix the breakage:
> - backport 02826a6ba301b
> OR
> - revert 638ecaf58369.
Alrighty, I've picked 02826a6ba301b for 4.19, thanks.
--
Thanks,
Sasha
prev parent reply other threads:[~2019-04-11 13:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 17:35 syncconfig changes in 4.19.34 break builds Ivan Babrou
2019-04-09 2:01 ` Masahiro Yamada
2019-04-09 3:47 ` Ivan Babrou
2019-04-09 5:39 ` Masahiro Yamada
2019-04-09 5:50 ` Masahiro Yamada
2019-04-09 15:39 ` Sasha Levin
2019-04-11 4:27 ` Masahiro Yamada
2019-04-11 13:47 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411134749.GH11568@sasha-vm \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ivan@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox