Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

Logan Gunthorpe
2019-05-03T03:19:24Z

On 2019-05-01 5:01 p.m., Brendan Higgins wrote:
> ## TLDR
>
> I rebased the last patchset on 5.1-rc7 in hopes that we can get this in
> 5.2.
>

As I said on the last posting, I like this and would like to see it move
forward. I still have the same concerns over the downsides of using UML
(ie. not being able to compile large swaths of the tree due to features
that don't exist in that arch) but these are concerns for later.

I'd prefer to see the unnecessary indirection that I pointed out in
patch 8 cleaned up but, besides that, the code looks good to me.

Reviewed-by: Logan Gunthorpe <logang@deltatee.com>

Thanks!

Logan