public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
* [kbuild:kunit 6/17] kunit/kunit-stream.c:14:12: sparse: sparse: symbol 'kunit_stream_get_level' was not declared. Should it be static?
@ 2019-05-10  7:32 kbuild test robot
  2019-05-10  7:32 ` [RFC PATCH kbuild] kbuild: kunit_stream_get_level() can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2019-05-10  7:32 UTC (permalink / raw)
  To: Brendan Higgins; +Cc: kbuild-all, linux-kbuild, Masahiro Yamada

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git kunit
head:   c505c0b2e6237c729634327c178f5b0094f1c958
commit: 7ab313d288d1c686ae39c7052f6ed6426ed38b54 [6/17] kbuild: enable building KUnit
reproduce:
        # apt-get install sparse
        git checkout 7ab313d288d1c686ae39c7052f6ed6426ed38b54
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> kunit/kunit-stream.c:14:12: sparse: sparse: symbol 'kunit_stream_get_level' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC PATCH kbuild] kbuild: kunit_stream_get_level() can be static
  2019-05-10  7:32 [kbuild:kunit 6/17] kunit/kunit-stream.c:14:12: sparse: sparse: symbol 'kunit_stream_get_level' was not declared. Should it be static? kbuild test robot
@ 2019-05-10  7:32 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2019-05-10  7:32 UTC (permalink / raw)
  To: Brendan Higgins; +Cc: kbuild-all, linux-kbuild, Masahiro Yamada


Fixes: 7ab313d288d1 ("kbuild: enable building KUnit")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 kunit-stream.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kunit/kunit-stream.c b/kunit/kunit-stream.c
index 93c14ee..3d92646 100644
--- a/kunit/kunit-stream.c
+++ b/kunit/kunit-stream.c
@@ -11,7 +11,7 @@
 #include <kunit/kunit-stream.h>
 #include <kunit/string-stream.h>
 
-const char *kunit_stream_get_level(struct kunit_stream *this)
+static const char *kunit_stream_get_level(struct kunit_stream *this)
 {
 	unsigned long flags;
 	const char *level;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-10  7:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-10  7:32 [kbuild:kunit 6/17] kunit/kunit-stream.c:14:12: sparse: sparse: symbol 'kunit_stream_get_level' was not declared. Should it be static? kbuild test robot
2019-05-10  7:32 ` [RFC PATCH kbuild] kbuild: kunit_stream_get_level() can be static kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox