From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f195.google.com ([209.85.214.195]:36458 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726295AbfENIMb (ORCPT ); Tue, 14 May 2019 04:12:31 -0400 Received: by mail-pl1-f195.google.com with SMTP id d21so7881692plr.3 for ; Tue, 14 May 2019 01:12:30 -0700 (PDT) Date: Tue, 14 May 2019 01:12:23 -0700 From: Brendan Higgins Subject: Re: [PATCH v3 08/18] objtool: add kunit_try_catch_throw to the noreturn list Message-ID: <20190514081223.GA230665@google.com> References: <20190514054251.186196-1-brendanhiggins@google.com> <20190514054251.186196-9-brendanhiggins@google.com> <20190514065643.GC2589@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190514065643.GC2589@hirez.programming.kicks-ass.net> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Peter Zijlstra Cc: frowand.list@gmail.com, gregkh@linuxfoundation.org, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, robh@kernel.org, sboyd@kernel.org, shuah@kernel.org, tytso@mit.edu, yamada.masahiro@socionext.com, Josh Poimboeuf , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, Tim.Bird@sony.com, amir73il@gmail.com, dan.carpenter@oracle.com, dan.j.williams@intel.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, knut.omang@oracle.com, logang@deltatee.com, mpe@ellerman.id.au, pmladek@suse.com, rdunlap@infradead.org, richard@nod.at, rientjes@google.com, rostedt@goodmis.org, wfg@linux.intel.com, kbuild test robot On Tue, May 14, 2019 at 08:56:43AM +0200, Peter Zijlstra wrote: > On Mon, May 13, 2019 at 10:42:42PM -0700, Brendan Higgins wrote: > > This fixes the following warning seen on GCC 7.3: > > kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch() > > > > What is that file and function; no kernel tree near me seems to have > that. Oh, sorry about that. The function is added in the following patch, "[PATCH v3 09/18] kunit: test: add support for test abort"[1]. My apologies if this patch is supposed to come after it in sequence, but I assumed it should come before otherwise objtool would complain about the symbol when it is introduced. Thanks! [1] https://lkml.org/lkml/2019/5/14/44