From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f196.google.com ([209.85.215.196]:45838 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726295AbfENSIS (ORCPT ); Tue, 14 May 2019 14:08:18 -0400 Received: by mail-pg1-f196.google.com with SMTP id i21so8993960pgi.12 for ; Tue, 14 May 2019 11:08:17 -0700 (PDT) Date: Tue, 14 May 2019 11:08:10 -0700 From: Brendan Higgins Subject: Re: [PATCH v3 15/18] Documentation: kunit: add documentation for KUnit Message-ID: <20190514180810.GA109557@google.com> References: <20190514054251.186196-1-brendanhiggins@google.com> <20190514054251.186196-16-brendanhiggins@google.com> <20190514073422.4287267c@lwn.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190514073422.4287267c@lwn.net> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Jonathan Corbet Cc: frowand.list@gmail.com, gregkh@linuxfoundation.org, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, robh@kernel.org, sboyd@kernel.org, shuah@kernel.org, tytso@mit.edu, yamada.masahiro@socionext.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, Tim.Bird@sony.com, amir73il@gmail.com, dan.carpenter@oracle.com, dan.j.williams@intel.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, knut.omang@oracle.com, logang@deltatee.com, mpe@ellerman.id.au, pmladek@suse.com, rdunlap@infradead.org, richard@nod.at, rientjes@google.com, rostedt@goodmis.org, wfg@linux.intel.com, Felix Guo On Tue, May 14, 2019 at 07:34:22AM -0600, Jonathan Corbet wrote: > On Mon, 13 May 2019 22:42:49 -0700 > Brendan Higgins wrote: > > > Add documentation for KUnit, the Linux kernel unit testing framework. > > - Add intro and usage guide for KUnit > > - Add API reference > > > > Signed-off-by: Felix Guo > > Signed-off-by: Brendan Higgins > > Reviewed-by: Greg Kroah-Hartman > > Reviewed-by: Logan Gunthorpe > > --- > > Changes Since Last Revision: > > - Addressed reference to incorrect number of sections, as per Randy's > > comment. > > - Make section underlines same length as the section title, as per > > Randy's comments. > > --- > > Documentation/index.rst | 1 + > > Documentation/kunit/api/index.rst | 16 + > > Documentation/kunit/api/test.rst | 14 + > > Documentation/kunit/faq.rst | 62 ++++ > > Documentation/kunit/index.rst | 79 ++++ > > Documentation/kunit/start.rst | 180 ++++++++++ > > Documentation/kunit/usage.rst | 575 ++++++++++++++++++++++++++++++ > > Certainly it's great to see all this documentation coming with this > feature! > > Naturally, though, I have one request: I'd rather not see this at the top > level, which is more than crowded enough as it is. Can this material > please go into the development tools book, alongside the kselftest > documentation? Oh yeah, that seems like the obvious home for this in hindsight. Sorry about that. Will fix in next revision! Thanks!