* [PATCH] kbuild: Remove -Waggregate-return from scripts/Makefile.extrawarn
@ 2019-05-29 8:04 Mathieu Malaterre
2019-06-04 17:09 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Mathieu Malaterre @ 2019-05-29 8:04 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Mathieu Malaterre, Michal Marek, linux-kbuild, linux-kernel
It makes little sense to pass -Waggregate-return these days since large
part of the linux kernel rely on returning struct(s). For instance:
../include/linux/timekeeping.h: In function 'show_uptime':
../include/linux/ktime.h:91:34: error: function call has aggregate value [-Werror=aggregate-return]
#define ktime_to_timespec64(kt) ns_to_timespec64((kt))
^~~~~~~~~~~~~~~~~~~~~~
../include/linux/timekeeping.h:166:8: note: in expansion of macro 'ktime_to_timespec64'
*ts = ktime_to_timespec64(ktime_get_coarse_boottime());
Remove this warning from W=2 completely.
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
| 1 -
1 file changed, 1 deletion(-)
--git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
index 3ab8d1a303cd..98081ab300e5 100644
--- a/scripts/Makefile.extrawarn
+++ b/scripts/Makefile.extrawarn
@@ -34,7 +34,6 @@ warning-1 += $(call cc-option, -Wstringop-truncation)
warning-1 += -Wno-missing-field-initializers
warning-1 += -Wno-sign-compare
-warning-2 := -Waggregate-return
warning-2 += -Wcast-align
warning-2 += -Wdisabled-optimization
warning-2 += -Wnested-externs
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] kbuild: Remove -Waggregate-return from scripts/Makefile.extrawarn
2019-05-29 8:04 [PATCH] kbuild: Remove -Waggregate-return from scripts/Makefile.extrawarn Mathieu Malaterre
@ 2019-06-04 17:09 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2019-06-04 17:09 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Michal Marek, Linux Kbuild mailing list,
Linux Kernel Mailing List
On Wed, May 29, 2019 at 5:16 PM Mathieu Malaterre <malat@debian.org> wrote:
>
> It makes little sense to pass -Waggregate-return these days since large
> part of the linux kernel rely on returning struct(s). For instance:
>
> ../include/linux/timekeeping.h: In function 'show_uptime':
> ../include/linux/ktime.h:91:34: error: function call has aggregate value [-Werror=aggregate-return]
> #define ktime_to_timespec64(kt) ns_to_timespec64((kt))
> ^~~~~~~~~~~~~~~~~~~~~~
> ../include/linux/timekeeping.h:166:8: note: in expansion of macro 'ktime_to_timespec64'
> *ts = ktime_to_timespec64(ktime_get_coarse_boottime());
>
> Remove this warning from W=2 completely.
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
Applied to linux-kbuild. Thanks.
> scripts/Makefile.extrawarn | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
> index 3ab8d1a303cd..98081ab300e5 100644
> --- a/scripts/Makefile.extrawarn
> +++ b/scripts/Makefile.extrawarn
> @@ -34,7 +34,6 @@ warning-1 += $(call cc-option, -Wstringop-truncation)
> warning-1 += -Wno-missing-field-initializers
> warning-1 += -Wno-sign-compare
>
> -warning-2 := -Waggregate-return
> warning-2 += -Wcast-align
> warning-2 += -Wdisabled-optimization
> warning-2 += -Wnested-externs
> --
> 2.20.1
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-04 17:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-29 8:04 [PATCH] kbuild: Remove -Waggregate-return from scripts/Makefile.extrawarn Mathieu Malaterre
2019-06-04 17:09 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox