From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f195.google.com ([209.85.215.195]:33824 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729740AbfFYRb2 (ORCPT ); Tue, 25 Jun 2019 13:31:28 -0400 Received: by mail-pg1-f195.google.com with SMTP id p10so9312573pgn.1 for ; Tue, 25 Jun 2019 10:31:28 -0700 (PDT) Date: Tue, 25 Jun 2019 10:31:26 -0700 From: Kees Cook Subject: Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs Message-ID: <201906251029.08B862130@keescook> References: <20190625160103.GA13133@embeddedor> <2bdbbd7909c5c4ad96d32c0c5be4690292132a34.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2bdbbd7909c5c4ad96d32c0c5be4690292132a34.camel@perches.com> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Joe Perches Cc: "Gustavo A. R. Silva" , Jingoo Han , Bartlomiej Zolnierkiewicz , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Masahiro Yamada , Michal Marek , linux-kbuild On Tue, Jun 25, 2019 at 09:52:23AM -0700, Joe Perches wrote: > On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch > > cases where we are expecting to fall through. > [] > > This patch is part of the ongoing efforts to enable > > -Wimplicit-fallthrough. > > Just enable the thing already. Linus has been pretty clear about not wanting warning options enabled without first fixing all the cases it warns about first. If that's changed, then sure, let's do it; but we went through a lot of coordination with sfr for linux-next nag-mail coverage (where maintainers are now fixing it themselves) when this came up during the last kernel summit, and this approach was the agreed solution. -- Kees Cook