Re: [RFC PATCH] modpost: check for static EXPORT_SYMBOL* functions

Masahiro Yamada
2019-07-28T02:00:50Z

Hi.

On Sun, Jul 28, 2019 at 4:14 AM Denis Efremov <efremov@linux.com> wrote:
>
> Hi.
>
> > Could you drop the solved ones from the list?
>
> Yes, of course. Do you want me to remove all symbols fixed with patches
> or only those are in-tree now?
>
> Should it be like this:
> 1. "torture_onoff_cleanup" [kernel/torture]
> "torture_shuffle_cleanup" [kernel/torture]
> Patch: https://lkml.org/lkml/2019/7/4/411 (accepted)
> 2. "LZ4HC_setExternalDict" [lib/lz4/lz4hc_compress]
> Patch: https://lkml.org/lkml/2019/7/8/842
> 3. "drm_client_close" [drivers/gpu/drm/drm]
> Patch: https://lkml.org/lkml/2019/7/3/758 (accepted)
> 4. "ahci_em_messages" [drivers/ata/libahci]
> Patch: https://lkml.org/lkml/2019/7/10/550 (reviewed)
> 5. "ftrace_set_clr_event" [vmlinux]
> Patch: https://lkml.org/lkml/2019/7/4/609 (reviewed)
> 6. "rmi_2d_sensor_set_input_params" [drivers/input/rmi4/rmi_core]
> Patch: https://lkml.org/lkml/2019/7/8/999 (accepted)
> 10. "empty_zero_page" [vmlinux]
> 11. "phys_base" [vmlinux]
> 12. "hypercall_page" [vmlinux]
>
> Or like this:
> 1. "empty_zero_page" [vmlinux]
> 2. "phys_base" [vmlinux]
> 3. "hypercall_page" [vmlinux]
>
> Well, I could remove this list at all. It seems like the following list
> with existing commits is enough to show the problem of static exported
> functions.

Yeah, I agree.
Showing some existing commits is enough.

> I will resend the patch shortly after.
>
> Regards,
> Denis

--
Best Regards
Masahiro Yamada