From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:37898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727830AbfJGQnk (ORCPT ); Mon, 7 Oct 2019 12:43:40 -0400 Date: Mon, 7 Oct 2019 18:43:33 +0200 From: Jessica Yu Subject: Re: [PATCH v2 0/6] module: various bug-fixes and clean-ups for module namespace Message-ID: <20191007164332.GA6021@linux-8ccs> References: <20191003075826.7478-1-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20191003075826.7478-1-yamada.masahiro@socionext.com> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Masahiro Yamada Cc: Matthias Maennich , Greg Kroah-Hartman , Shaun Ruffell , linux-kbuild@vger.kernel.org, Martijn Coenen , Michal Marek , Will Deacon , linux-kernel@vger.kernel.org +++ Masahiro Yamada [03/10/19 16:58 +0900]: > >I was hit by some problems caused by the module namespace feature >that was merged recently. At least, the breakage of >external module builds is a fatal one. I just took a look at the code >closer, and I noticed some more issues (some are nit-picking). > >V2: > - I dropped "module: avoid code duplication in include/linux/export.h" > because Matthias offered to refactor the code by himself. > > - V1 missed the problem when a symbol is preloaded before > sym_add_exported() is called. I fixed it too. Hi Masahiro! Thanks for the v2. I've queued this up in the module tree with the intention of getting the fixes in for -rc3. Matthias is working on some modpost fixes that would get rid of the __ksymtab_./__ksymtab_. naming scheme altogether in favor of just getting the namespace string from __kstrtabns and __ksymtab_strings -- this may render patch 1 unnecessary. But since we want to fix this asap, we can just keep it and apply Matthias's fix on top later. Thanks! Jessica