Re: [PATCH v4] kallsyms: add names of built-in modules

Masahiro Yamada
2019-12-19T10:22:47Z

On Thu, Dec 19, 2019 at 1:28 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Thu, Dec 19, 2019 at 12:29 PM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > On Wed, 18 Dec 2019 15:55:18 -0800
> > Eugene Loh <eugene.loh@oracle.com> wrote:
> >
> > > Ping.
> >
> > Couple of notes:
> >
> > 1) this affects code that doesn't really have a maintainer. I could
> > take it in my tree, but I would like to have acks from other
> > maintainers. Perhaps Jessica Yu (Module maintainer), and probably one
> > from Linus himself.
> >
> > 2) Do not send new versions of a patch as a reply to the old version. I
> > and many other maintainers sort our inbox by threads, and I look at the
> > top of the thread for patches. That is, if there's another version of a
> > patch that is a reply to a previous version, it is basically off my
> > radar, unless I happen to notice it by chance (which I did with this
> > email).
> >
> > You can send your v4 patch again, but please send it as its own thread,
> > that way it will be on the radar of other maintainers. Hopefully we can
> > get some acks on this as well.
> >
> > -- Steve
>
>
> I do not like this patch.
>
> scripts/Makefile.modbuiltin is really ugly.
> It traverses all the directories once again.
>
> This patch makes it even worse,
> Kbuild would traverse the
> whole directories three times.
>
> I was thinking to remove scripts/Makefile.modbuiltin
> and Kconfig's tristate.conf entirely
> because it is possible to generate modules.builtin more simply.

FYI: This is the idea I had in my mind:
https://lore.kernel.org/patchwork/project/lkml/list/?series=423205

--
Best Regards
Masahiro Yamada