From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from elvis.franken.de ([193.175.24.41]:55913 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727192AbgDFLgU (ORCPT ); Mon, 6 Apr 2020 07:36:20 -0400 Date: Mon, 6 Apr 2020 13:03:33 +0200 From: Thomas Bogendoerfer Subject: Re: [PATCH] MIPS: fw: arc: add __weak to prom_meminit and prom_free_prom_memory Message-ID: <20200406110333.GA6266@alpha.franken.de> References: <20200405163052.18942-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200405163052.18942-1-masahiroy@kernel.org> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-mips@linux-mips.org, clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org, Jiaxun Yang , Paul Burton , linux-mips@vger.kernel.org On Mon, Apr 06, 2020 at 01:30:52AM +0900, Masahiro Yamada wrote: > As far as I understood, prom_meminit() in arch/mips/fw/arc/memory.c > is overridden by the one in arch/mips/sgi-ip32/ip32-memory.c if > CONFIG_SGI_IP32 is enabled. > > The use of EXPORT_SYMBOL in static libraries potentially causes a > problem for the llvm linker [1]. So, I want to forcibly link lib-y > objects to vmlinux when CONFIG_MODULES=y. > > As a groundwork, we must fix multiple definitions that have previously > been hidden by lib-y. > > The prom_cleanup() in this file is already marked as __weak (because > it is overridden by the one in arch/mips/sgi-ip22/ip22-mc.c). > I think it should be OK to do the same for these two. > > [1]: https://github.com/ClangBuiltLinux/linux/issues/515 > > Reported-by: kbuild test robot > Signed-off-by: Masahiro Yamada > --- > > If MIPS maintainers ack this patch, > I want to inser it before the following patch: Acked-By: Thomas Bogendoerfer Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]