From: Sami Tolvanen <samitolvanen@google.com>
To: Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>
Cc: Kees Cook <keescook@chromium.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Sami Tolvanen <samitolvanen@google.com>
Subject: [PATCH] kbuild: reuse vmlinux.o in vmlinux_link
Date: Thu, 21 May 2020 13:27:16 -0700 [thread overview]
Message-ID: <20200521202716.193316-1-samitolvanen@google.com> (raw)
Instead of linking all compilation units again each time vmlinux_link is
called, reuse vmlinux.o from modpost_link.
With x86_64 allyesconfig, vmlinux_link is called three times and reusing
vmlinux.o reduces the build time ~38 seconds on my system (59% reduction
in the time spent in vmlinux_link).
Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
---
scripts/link-vmlinux.sh | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
index d09ab4afbda4..c6cc4305950c 100755
--- a/scripts/link-vmlinux.sh
+++ b/scripts/link-vmlinux.sh
@@ -77,11 +77,8 @@ vmlinux_link()
if [ "${SRCARCH}" != "um" ]; then
objects="--whole-archive \
- ${KBUILD_VMLINUX_OBJS} \
+ vmlinux.o \
--no-whole-archive \
- --start-group \
- ${KBUILD_VMLINUX_LIBS} \
- --end-group \
${@}"
${LD} ${KBUILD_LDFLAGS} ${LDFLAGS_vmlinux} \
base-commit: b85051e755b0e9d6dd8f17ef1da083851b83287d
--
2.27.0.rc0.183.gde8f92d652-goog
next reply other threads:[~2020-05-21 20:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 20:27 Sami Tolvanen [this message]
2020-05-21 22:08 ` [PATCH] kbuild: reuse vmlinux.o in vmlinux_link Kees Cook
2020-05-22 18:16 ` Masahiro Yamada
2020-05-21 22:18 ` Kees Cook
2020-05-22 17:41 ` Masahiro Yamada
2020-05-22 17:44 ` Masahiro Yamada
2020-05-23 10:06 ` Nicholas Piggin
2020-05-23 15:12 ` Masahiro Yamada
2020-05-23 16:53 ` Sam Ravnborg
2020-05-25 6:13 ` Masahiro Yamada
2020-06-15 21:47 ` Sami Tolvanen
2020-06-16 3:22 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521202716.193316-1-samitolvanen@google.com \
--to=samitolvanen@google.com \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox