From: Domenico Andreoli <domenico.andreoli@linux.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Olof Johansson <olof@lixom.net>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH v2] kbuild: buildtar: add arm64 dtbs support
Date: Fri, 26 Jun 2020 23:40:26 +0200 [thread overview]
Message-ID: <20200626214026.GB25753@dumbo> (raw)
In-Reply-To: <CAK7LNASta=UfbK-C=6R+tT2nug8_MYyr9515J4CN8odWCh0CpA@mail.gmail.com>
On Fri, Jun 26, 2020 at 03:16:58PM +0900, Masahiro Yamada wrote:
> On Fri, Jun 26, 2020 at 5:51 AM Domenico Andreoli
> <domenico.andreoli@linux.com> wrote:
> >
> > From: Domenico Andreoli <domenico.andreoli@linux.com>
> >
> > Make 'make tar-pkg' install dtbs on arm64.
> >
> > Signed-off-by: Domenico Andreoli <domenico.andreoli@linux.com>
> >
> > v2:
> > - Destination path includes the kernel version, as expected
> >
> > ---
> > scripts/package/buildtar | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > Index: b/scripts/package/buildtar
> > ===================================================================
> > --- a/scripts/package/buildtar
> > +++ b/scripts/package/buildtar
> > @@ -125,6 +125,15 @@ case "${ARCH}" in
> > ;;
> > esac
> >
> > +#
> > +# Install dtbs
> > +#
> > +case "${ARCH}" in
>
> Instead of checking ${ARCH},
> can you you do
>
> if grep -q '^CONFIG_OF_EARLY_FLATTREE=y' include/config/auto.conf; then
>
> ?
Done in v3.
>
> This is what the deb package build does:
> https://github.com/masahir0y/linux/blob/v5.7/scripts/package/builddeb#L145
>
>
> > + arm64)
> > + make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_DTBS_PATH="${tmpdir}/boot/dtbs/${KERNELRELEASE}" dtbs_install
> > + ;;
> > +esac
> > +
>
>
> Or, you can use INSTALL_PATH="${tmpdir}/boot"
> to make it shorter.
This does not work, INSTALL_DTBS_PATH gets somehow defined along the
twisted path to buildtar and therefore needs to be explicitly specified
for the new destination.
> --
> Best Regards
> Masahiro Yamada
Thank you for the review.
Regards,
Domenico
--
rsa4096: 3B10 0CA1 8674 ACBA B4FE FCD2 CE5B CF17 9960 DE13
ed25519: FFB4 0CC3 7F2E 091D F7DA 356E CC79 2832 ED38 CB05
next prev parent reply other threads:[~2020-06-26 21:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 20:51 [PATCH v2] kbuild: buildtar: add arm64 dtbs support Domenico Andreoli
2020-06-26 6:16 ` Masahiro Yamada
2020-06-26 21:40 ` Domenico Andreoli [this message]
2020-06-27 12:02 ` Masahiro Yamada
2020-06-27 21:21 ` Domenico Andreoli
2020-06-28 3:46 ` Masahiro Yamada
2020-06-28 17:46 ` Domenico Andreoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200626214026.GB25753@dumbo \
--to=domenico.andreoli@linux.com \
--cc=catalin.marinas@arm.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=olof@lixom.net \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox