From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726379AbgGCQGT (ORCPT ); Fri, 3 Jul 2020 12:06:19 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06FD0C08C5DD for ; Fri, 3 Jul 2020 09:06:19 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id f16so3794288pjt.0 for ; Fri, 03 Jul 2020 09:06:19 -0700 (PDT) Date: Fri, 3 Jul 2020 09:06:16 -0700 From: Kees Cook Subject: Re: Kernel compression benchmarks Message-ID: <202007030855.ED7AABDF@keescook> References: <1588791882.08g1378g67.none.ref@localhost> <1588791882.08g1378g67.none@localhost> <202007020818.87EA89106@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Nick Terrell , Nick Terrell Cc: Sedat Dilek , "Alex Xu (Hello71)" , linux-kernel@vger.kernel.org, Norbert Lange , Chris Mason , linux-kbuild@vger.kernel.org, x86@kernel.org, gregkh@linuxfoundation.org, Petr Malat , Kernel Team , Adam Borowski , Patrick Williams , rmikey@fb.com, mingo@kernel.org, Patrick Williams On Fri, Jul 03, 2020 at 10:15:20AM +0200, Sedat Dilek wrote: > On Thu, Jul 2, 2020 at 5:18 PM Kees Cook wrote: > > > > On Wed, Jul 01, 2020 at 10:35:48AM -0400, Alex Xu (Hello71) wrote: > > > ZSTD compression patches have been sent in a number of times over the > > > past few years. Every time, someone asks for benchmarks. Every time, > > > someone is concerned about compression time. Sometimes, someone provides > > > benchmarks. > > > > Where's the latest series for this, btw? I thought it had landed. :P It > > seemed like it was done. > > > > Hi, > > Again, I would like to see this upstream, too. > > Last I asked for a rebase against Linux v5.8-rc1 or later. > > Beyond above adaptations, the latest series "zstd-v5" of Nick T.s > patchset needs some addition of zstd to the patch (see [1]): > > commit 8dfb61dcbaceb19a5ded5e9c9dcf8d05acc32294 > "kbuild: add variables for compression tools" > > NOTE: > "zstd-v5" was against Linux-next 20200408 or download the series from > patchwork LKML which applies cleanly against Linux v5.7 - last is what > I did. > > There was a follow-up to the above patch (see [2]): > > commit e4a42c82e943b97ce124539fcd7a47445b43fa0d > "kbuild: fix broken builds because of GZIP,BZIP2,LZOP variables" Okay, cool. Yes, now is the right time to send an updated series based on v5.8-rc2 with any outstanding adjusted/fixes made. It seems v5 is here? https://lore.kernel.org/lkml/20200408215711.137639-1-nickrterrell@gmail.com/ That wasn't sent "to" a maintainer, so it likely went unnoticed by either akpm or the x86 maintainers. I think this should likely go via the x86 tree. > Nevertheless, this is the kernel-side of doing - user-space like for > example Debian's initramfs-tools needs adaptations (see [3]). Right, but the kernel needs to implement the support first. :) > @Kees: Can you aid Nick T. to get this upstream? You know the > processes a bit better than me. Sure; Nick, can you please rebase and handle any issues from v5? With the result, send a v6 as you did for v5 before, but I would make your "to" be: Borislav Petkov Thomas Gleixner and keep the CC as you had it. -- Kees Cook