From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728852AbgGGVcP (ORCPT ); Tue, 7 Jul 2020 17:32:15 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39B86C061755 for ; Tue, 7 Jul 2020 14:32:15 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id w2so19801003pgg.10 for ; Tue, 07 Jul 2020 14:32:15 -0700 (PDT) Date: Tue, 7 Jul 2020 14:32:12 -0700 From: Kees Cook Subject: Re: [GIT PULL][PATCH v6 0/8] Add support for ZSTD-compressed kernel and initramfs Message-ID: <202007071422.1060F5932@keescook> References: <20200707034604.1539157-1-nickrterrell@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200707034604.1539157-1-nickrterrell@gmail.com> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Borislav Petkov , Thomas Gleixner , x86@kernel.org Cc: Nick Terrell , linux-kernel@vger.kernel.org, Chris Mason , linux-kbuild@vger.kernel.org, gregkh@linuxfoundation.org, Petr Malat , Kernel Team , Adam Borowski , Patrick Williams , rmikey@fb.com, mingo@kernel.org, Patrick Williams , Sedat Dilek , Norbert Lange , Andrew Morton , Nick Terrell On Mon, Jul 06, 2020 at 08:45:56PM -0700, Nick Terrell wrote: > From: Nick Terrell > > Please pull from > > git@github.com:terrelln/linux.git tags/v6-zstd > > to get these changes. Alternatively the patchset is included. > > Hi all, > > This patch set adds support for a ZSTD-compressed kernel, ramdisk, and > initramfs in the kernel boot process. ZSTD-compressed ramdisk and initramfs > are supported on all architectures. The ZSTD-compressed kernel is only > hooked up to x86 in this patch set. Hello x86 maintainers! I think this series is ready to go. Notes below... > [...] > x86: bump ZO_z_extra_bytes margin for zstd The above patch is really the only thing that has any external visibility to kernels that have ZSTD disabled. Given the ratios of memory sizes involved (an extra 64K when we're dealing with 2MB windows) seems reasonable to me. If that isn't acceptable, it should be trivial to make it CONFIG-selectable (like we already do with BOOT_HEAP_SIZE). What do you think? If the non-x86 parts should land first in -mm, I guess that would be okay, but I think it makes sense for all of this to go via -tip. -Kees -- Kees Cook