From: Josh Triplett <josh@joshtriplett.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Michal Marek <michal.lkml@markovi.net>
Subject: Re: "make bindeb-pkg" fails with CONFIG_MODULES disabled
Date: Tue, 20 Oct 2020 10:21:15 -0700 [thread overview]
Message-ID: <20201020172115.GA135202@localhost> (raw)
In-Reply-To: <CAK7LNATJZJyMBLkXbCib1B0uZ2qgNyAVkCfA4x=oR8ww73F9jw@mail.gmail.com>
On Wed, Oct 14, 2020 at 01:48:28AM +0900, Masahiro Yamada wrote:
> On Sat, Sep 26, 2020 at 5:45 PM Josh Triplett <josh@joshtriplett.org> wrote:
> >
> > On Sat, Sep 26, 2020 at 02:45:38PM +0900, Masahiro Yamada wrote:
> > > On Sat, Sep 26, 2020 at 7:29 AM Josh Triplett <josh@joshtriplett.org> wrote:
> > > >
> > > > With CONFIG_MODULES disabled, "make bindeb-pkg" fails in
> > > > scripts/package/builddeb with:
> > > >
> > > > find: ‘Module.symvers’: No such file or directory
> > > >
> > > > The deploy_kernel_headers function in scripts/package/builddeb calls:
> > > >
> > > > find arch/$SRCARCH/include Module.symvers include scripts -type f
> > > >
> > > > But find errors out if any of its command-line arguments doesn't exist.
> > > >
> > > > This could be fixed by checking whether that file exists first, but if
> > > > CONFIG_MODULES is disabled, it doesn't really make sense to build the
> > > > linux-headers package at all. Perhaps that whole package could be
> > > > disabled when modules are disabled?
> > >
> > > I agree.
> > >
> > >
> > > How about something like the following?
> >
> > That looks good to me.
> >
> > (It would be nice, as well, to have some conditional wrapped around the
> > linux-libc-dev package. I had a patch for that a while ago at
> > https://lore.kernel.org/lkml/b45738b05bb396e175a36f67b02fa01de4c7472f.1583912084.git.josh@joshtriplett.org/
> > , but that's probably not the ideal way to do it. I'd love to see a way
> > to disable that extra deb, though, as it adds time to the deb build
> > process for a package that most people looking to build a deb won't
> > need or install.)
>
> I am skeptical about this approach.
>
>
> I think the ideal way would be
> to support individual binary package build in dpkg-buildpackage.
>
> I do not know if it has been already achieved, or
> it is a planned feature.
Given the way Debian packages are built, that's not really an option.
There are targets in debian/rules to build arch-specific and
arch-independent packages, but not targets to build individual binary
packages.
Are you more concerned about avoiding the code conditionally generating
the control file, or about avoiding the code that has to pass the
controlling environment variable down through build steps?
prev parent reply other threads:[~2020-10-20 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 22:29 "make bindeb-pkg" fails with CONFIG_MODULES disabled Josh Triplett
2020-09-26 5:45 ` Masahiro Yamada
2020-09-26 8:45 ` Josh Triplett
2020-10-13 16:48 ` Masahiro Yamada
2020-10-20 17:21 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020172115.GA135202@localhost \
--to=josh@joshtriplett.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox