From: Petr Vorel <petr.vorel@gmail.com>
To: linux-kbuild@vger.kernel.org
Cc: Petr Vorel <petr.vorel@gmail.com>,
Guillem Jover <guillem@hadrons.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Ben Hutchings <ben@decadent.org.uk>
Subject: [PATCH] builddeb: Fix build on non-Debian/Ubuntu distros
Date: Fri, 30 Oct 2020 17:56:07 +0100 [thread overview]
Message-ID: <20201030165607.290612-1-petr.vorel@gmail.com> (raw)
This fixes make bindeb-pkg for RPM based distros, which don't have
dpkg-dev (and thus not /usr/bin/dpkg-buildpackage), which sets
$DEB_RULES_REQUIRES_ROOT.
Fixes: 3e8541803624 ("builddeb: Enable rootless builds")
Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
Hi,
I admit not many people compile kernel with bindeb-pkg on RPM based
distro, but it'd be nice it were working.
openSUSE has most of other required packages, although there are some
missing dependencies, thus DPKG_FLAGS="-d" is needed.
Kind regards,
Petr
scripts/package/builddeb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index 1b11f8993629..287e4bbd222c 100755
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -37,7 +37,7 @@ create_package() {
| xargs -r0 md5sum > DEBIAN/md5sums"
# Fix ownership and permissions
- if [ "$DEB_RULES_REQUIRES_ROOT" = "no" ]; then
+ if [ -z "$DEB_RULES_REQUIRES_ROOT" -o "$DEB_RULES_REQUIRES_ROOT" = "no" ]; then
dpkg_deb_opts="--root-owner-group"
else
chown -R root:root "$pdir"
--
2.27.0.rc0
next reply other threads:[~2020-10-30 16:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 16:56 Petr Vorel [this message]
2020-10-30 17:14 ` [PATCH] builddeb: Fix build on non-Debian/Ubuntu distros Ben Hutchings
2020-10-30 18:57 ` Petr Vorel
2020-11-02 8:35 ` Masahiro Yamada
2020-11-02 19:05 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030165607.290612-1-petr.vorel@gmail.com \
--to=petr.vorel@gmail.com \
--cc=ben@decadent.org.uk \
--cc=guillem@hadrons.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox