Re: [PATCH v6 22/25] x86/asm: annotate indirect jumps

Josh Poimboeuf
2020-11-14T00:49:46Z

On Fri, Nov 13, 2020 at 03:31:34PM -0800, Sami Tolvanen wrote:
> > #else /* !CONFIG_STACK_VALIDATION */
> > @@ -123,6 +129,8 @@ struct unwind_hint {
> > .macro UNWIND_HINT sp_reg:req sp_offset=0 type:req end=0
> > .endm
> > #endif
> > +.macro STACK_FRAME_NON_STANDARD func:req
> > +.endm
>
> This macro needs to be before the #endif, so it's defined only for
> assembly code. This breaks my arm64 builds even though x86 curiously
> worked just fine.

Yeah, I noticed that after syncing objtool.h with the tools copy. Fixed
now.

I've got fixes for some of the other warnings, but I'll queue them up
and post when they're all ready.

--
Josh