Re: [PATCH v6 02/25] objtool: Add a pass for generating __mcount_loc

Josh Poimboeuf
2020-10-15T20:10:20Z

On Wed, Oct 14, 2020 at 08:21:15PM +0200, Peter Zijlstra wrote:
> On Wed, Oct 14, 2020 at 06:50:04PM +0200, Ingo Molnar wrote:
> > Meh, adding --mcount as an option to 'objtool check' was a valid hack for a
> > prototype patchset, but please turn this into a proper subcommand, just
> > like 'objtool orc' is.
> >
> > 'objtool check' should ... keep checking. :-)
>
> No, no subcommands. orc being a subcommand was a mistake.

Yup, it gets real awkward when trying to combine subcommands.

I proposed a more logical design:

https://lkml.kernel.org/r/20201002141303.hyl72to37wudoi66@treble

--
Josh