From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21472C433DB for ; Fri, 15 Jan 2021 01:08:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA8A723A5E for ; Fri, 15 Jan 2021 01:08:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726201AbhAOBIb (ORCPT ); Thu, 14 Jan 2021 20:08:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbhAOBIa (ORCPT ); Thu, 14 Jan 2021 20:08:30 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71372C061575 for ; Thu, 14 Jan 2021 17:07:50 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id a206so3750832ybg.0 for ; Thu, 14 Jan 2021 17:07:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=vegfqptpw1wNPtbTqAfiW5JhWvOgA4LdeJqD1gHWX4E=; b=lOQmMFYv/aAziyh/CpnrmFrAuR95FZjxoihmzPKf5C20G5ryMDRKpfuRq8YbB7RmZ9 i7WQA/T7Gp4Annewc4jjMNWHnCq0u450OfGzqLyN6MR5kF+W5EBcECvrknNTLOTfoauK LhvokVXMoCM0VyqXGrMpmFt8GQ097SpFiwuvKNiadmE61sYGAVaE7dYeTpXKGaJo4/Dd rWFaK1EsooRQ8n5p3R2u4yuz9NVs2S5gCS8gk6LxELL46mzZs2R1YZ2yDT5/fzWOoo48 CMLCtq3nQ03KL0+WnQbb8EzeXKwa1dqxUSPfVD5/ALrfQrV9l/gnbtl25B+TqJiXIYHg PfgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=vegfqptpw1wNPtbTqAfiW5JhWvOgA4LdeJqD1gHWX4E=; b=nELc5XLLIXpYcA/Xox/urrMH963jvW2TvKyUDv7uTbAxba8NpCzVvK64hzIhB/c74C lzfd8LqYxGb8reheUGA13ZjZqi9Yj+TFCCFzLi8+NBeJqoupcQ0BD8zAPR7KFbqe5dp1 F9VD0yZAVS+KVbswhFBCovruZaGaFs1UdSG9tQFNFja2Koo5jIJmlv8c3YDq9wxvL42J MhNDDgz2R2tR2bsBF1DhZJ0fzOMo9Bdu5KubwlC+flafwzQu4vrPnRXZKcEbAG/mEHHw L7Apox5HglfQfoJCrRsmqwgyjpQmz0rTrESun62BunsO5iY1Nccs6HcMXTNVU3b1s/bw ByOQ== X-Gm-Message-State: AOAM531RcVQcJIg/RfUumLpPD9fTMEqTaVhPEpHk8a9PeMiD1qw3vSFR bY08+DsJh2n1+2Ptyqdfd/HLZf15OwR6QciCHu4= X-Google-Smtp-Source: ABdhPJxF5i0TbGLOYkGZ82ttxe9Qf3lU5+lSqU2BfXphVfUAUnBmPSlnU0vmlYu60m4pWXIfJluI9AxX3aNNbAPKUZs= Sender: "ndesaulniers via sendgmr" X-Received: from ndesaulniers1.mtv.corp.google.com ([2620:15c:211:202:f693:9fff:fef4:4d25]) (user=ndesaulniers job=sendgmr) by 2002:a25:d24a:: with SMTP id j71mr14341774ybg.13.1610672869563; Thu, 14 Jan 2021 17:07:49 -0800 (PST) Date: Thu, 14 Jan 2021 17:07:46 -0800 In-Reply-To: <1610500731-30960-1-git-send-email-jjohnson@codeaurora.org> Message-Id: <20210115010746.3839839-1-ndesaulniers@google.com> Mime-Version: 1.0 References: <1610500731-30960-1-git-send-email-jjohnson@codeaurora.org> X-Mailer: git-send-email 2.30.0.284.gd98b1dd5eaa7-goog Subject: Re: [PATCH 1/2] kbuild: simplify cmd_mod From: Nick Desaulniers To: jjohnson@codeaurora.org Cc: eberman@quicinc.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, masahiroy@kernel.org, michal.lkml@markovi.net, mkalikot@codeaurora.org, psodagud@quicinc.com, Sami Tolvanen , Nick Desaulniers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org > From: Mahesh Kumar Kalikot Veetil > > Modules with a large number of compilation units can exceed execv > argument list resulting in E2BIG (Argument list too long) error. > > Fix this by replacing shell 'echo > file' into a more native > $(file op filename[,text]) option. > > Signed-off-by: Mahesh Kumar Kalikot Veetil > Signed-off-by: Jeff Johnson > --- > scripts/Makefile.build | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > index 4c058f1..252b7d2 100644 > --- a/scripts/Makefile.build > +++ b/scripts/Makefile.build > @@ -279,10 +279,11 @@ $(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) FORCE > $(call if_changed_rule,cc_o_c) > $(call cmd,force_checksrc) > > -cmd_mod = { \ > - echo $(if $($*-objs)$($*-y)$($*-m), $(addprefix $(obj)/, $($*-objs) $($*-y) $($*-m)), $(@:.mod=.o)); \ > - $(undefined_syms) echo; \ > - } > $@ > +cmd_mod = $(file >$@,\ > + $(if $($*-objs)$($*-y)$($*-m), \ > + $(addprefix $(obj)/, $($*-objs) $($*-y) $($*-m)), \ > + $(@:.mod=.o))) \ > + $(undefined_syms) echo >> $@ I find the indendation to be a readability improvement. Thanks for the patch. Reviewed-by: Nick Desaulniers Tested-by: Nick Desaulniers > > $(obj)/%.mod: $(obj)/%.o FORCE > $(call if_changed,mod) > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > >