Re: [PATCH] kbuild: simplify access to the kernel's version

Masahiro Yamada
2021-02-11T20:21:09Z

On Tue, Feb 9, 2021 at 3:20 AM Sasha Levin <sashal@kernel.org> wrote:
>
> On Mon, Feb 08, 2021 at 05:50:07PM +0000, Christoph Hellwig wrote:
> >On Sun, Feb 07, 2021 at 11:13:52AM -0500, Sasha Levin wrote:
> >> + (u8)(LINUX_VERSION_MAJOR), (u8)(LINUX_VERSION_PATCHLEVEL),
> >> + (u16)(LINUX_VERSION_SUBLEVEL));
> >
> >No need for the casts and braces.
> >

I agree.

Shall I remove the casts when I apply this?

> >Otherwise this looks good, but please also kill off KERNEL_VERSION
> >and LINUX_KERNEL_VERSION entirely while you're at it.
>
> I don't think there are in-tree users left?
>
> We can't remove it completely because userspace is still using it, so if
> we drop those userspace will be sad.

Right.
Once we export a macros to userspace, we cannot remove it.

> --
> Thanks,
> Sasha

--
Best Regards
Masahiro Yamada